Page MenuHomeFreeBSD

Use unlocked page lookup for inmem() to avoid object lock contention
ClosedPublic

Authored by mlaier on Oct 3 2020, 6:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 28, 3:02 PM
Unknown Object (File)
Thu, Mar 26, 12:25 AM
Unknown Object (File)
Mon, Mar 23, 6:51 PM
Unknown Object (File)
Mon, Mar 23, 9:29 AM
Unknown Object (File)
Sun, Mar 22, 8:13 PM
Unknown Object (File)
Sun, Mar 22, 8:08 PM
Unknown Object (File)
Wed, Mar 18, 8:32 AM
Unknown Object (File)
Mon, Mar 9, 6:20 AM
Subscribers

Details

Summary

Let's try this again:

  • make a vm_page_lookup_unlocked
  • really bool-ify
  • while here, export inmem alongside incore (we have a local diff for this)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34004
Build 31193: arc lint + arc unit

Event Timeline

mlaier requested review of this revision.Oct 3 2020, 6:57 PM
mlaier created this revision.

Moving the tinc calculation back up - needed for valid range

markj added inline comments.
sys/vm/vm_page.c
1701

I think this deserves a comment to match the others. e.g., the description for vm_page_lookup(), plus, "The page may be no longer be present in the object at the time that this function returns."

This revision is now accepted and ready to land.Oct 6 2020, 12:47 PM

Add comment per markj's request.

This revision now requires review to proceed.Oct 8 2020, 10:14 PM
This revision is now accepted and ready to land.Oct 8 2020, 10:48 PM