Page MenuHomeFreeBSD
Differential D26618

Don't use install(1) for the library symlinks in the build directory
ClosedPublic
Actions

Authored by arichardson on Sep 30 2020, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 26, 6:57 PM
Unknown Object (File)
Sun, Jul 26, 1:07 AM
Unknown Object (File)
Mon, Jul 20, 9:03 AM
Unknown Object (File)
Sat, Jul 18, 5:48 PM
Unknown Object (File)
Sat, Jul 18, 2:36 AM
Unknown Object (File)
Sun, Jul 12, 12:28 PM
Unknown Object (File)
Sat, Jul 11, 8:48 AM
Unknown Object (File)
Sat, Jul 4, 8:52 AM
View All Files
Subscribers
bdrewery
imp

Details

Reviewers
brooks
emaste
Commits
rS366633: Don't use install(1) for the library symlinks in the build directory
Summary

It appears this was changed from ln to use install in rS245752. I noticed
this because my buildenv was setting INSTALL=install -U -M METALOG
and then these links fail to be created with the following error:
install: open METALOG: Permission denied

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33912
Build 31113: arc lint + arc unit

Event Timeline

arichardson created this revision.Sep 30 2020, 10:10 PM
Herald added a subscriber: bdrewery. · View Herald TranscriptSep 30 2020, 10:10 PM
arichardson requested review of this revision.Sep 30 2020, 10:10 PM
Harbormaster completed remote builds in B33910: Diff 77707.Sep 30 2020, 10:10 PM
brooks accepted this revision.Sep 30 2020, 10:21 PM

It might be worth a comment making clear this is in objdir since bare use of ln is almost always a bug.

This revision is now accepted and ready to land.Sep 30 2020, 10:21 PM
arichardson updated this revision to Diff 77709.Sep 30 2020, 10:47 PM
  • Add comment
This revision now requires review to proceed.Sep 30 2020, 10:47 PM
Harbormaster completed remote builds in B33912: Diff 77709.Sep 30 2020, 10:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 12 2020, 10:42 AM
Closed by commit rS366633: Don't use install(1) for the library symlinks in the build directory (authored by arichardson). · Explain Why
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS366633: Don't use install(1) for the library symlinks in the build directory.
Herald added a subscriber: imp. · View Herald TranscriptOct 12 2020, 10:42 AM
bdrewery added a comment.Oct 15 2020, 12:40 AM
This comment was removed by bdrewery.

Revision Contents
Changeset List

PathSize
share/
mk/
6 lines

Diff 77709

View Options

share/mk/bsd.lib.mk

Loading...