Paths

Table of Contentst

Differential D26616

zgrep: fix exit status with multiple files
ClosedPublic
Actions

Authored by vangyzen on Sep 30 2020, 9:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 11:18 AM

	Unknown Object (File)
	Sun, Feb 9, 11:17 AM

	Unknown Object (File)
	Sun, Feb 9, 11:17 AM

	Unknown Object (File)
	Fri, Jan 31, 9:32 PM

	Unknown Object (File)
	Sun, Jan 26, 4:16 AM

	Unknown Object (File)
	Sun, Jan 26, 2:28 AM

	Unknown Object (File)
	Thu, Jan 23, 3:05 PM

	Unknown Object (File)
	Dec 11 2024, 2:53 AM

View All 62 Files

Subscribers

Details

Reviewers

leres
kevans
ngie
dab

Commits

rS366345: zgrep: fix exit status with multiple files

Summary

zgrep should exit with success when given multiple files and the
pattern is found in at least one file. Prior to this change,
it would exit with success only if the pattern was found in _every_ file.

Test Plan

The added test case failed before the fix. All tests pass with the fix.

grep_test:zgrep_multiple_files  ->  passed  [0.022s]

Results file id is usr_tests_usr.bin_grep.20200930-212653-629287
Results saved to /root/.kyua/store/results.usr_tests_usr.bin_grep.20200930-212653-629287.db

52/52 passed (0 failed)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33908
Build 31109: arc lint + arc unit

Event Timeline

vangyzen created this revision.Sep 30 2020, 9:24 PM

Herald added a reviewer: ngie. · View Herald TranscriptSep 30 2020, 9:24 PM

Herald added subscribers: dab, badger. · View Herald Transcript

vangyzen requested review of this revision.Sep 30 2020, 9:24 PM

Harbormaster completed remote builds in B33908: Diff 77704.Sep 30 2020, 9:24 PM

vangyzen edited the test plan for this revision. (Show Details)Sep 30 2020, 9:24 PM

vangyzen edited the test plan for this revision. (Show Details)Sep 30 2020, 9:27 PM

dab accepted this revision.Oct 1 2020, 1:30 AM

This revision is now accepted and ready to land.Oct 1 2020, 1:30 AM

Macro shipit:

contrib/netbsd-tests/usr.bin/grep/t_grep.sh
898	`"Ensures that zgrep functions properly with multiple files"` would be a better comment.

vangyzen marked an inline comment as done.Oct 1 2020, 9:44 PM

vangyzen added inline comments.

contrib/netbsd-tests/usr.bin/grep/t_grep.sh
898	Indeed, it would. (I'm guilty of copy-and-paste.)

Closed by commit rS366345: zgrep: fix exit status with multiple files (authored by vangyzen). · Explain WhyOct 1 2020, 9:48 PM

This revision was automatically updated to reflect the committed changes.

vangyzen marked an inline comment as done.

vangyzen added a commit: rS366345: zgrep: fix exit status with multiple files.

Herald added a subscriber: imp. · View Herald TranscriptOct 1 2020, 9:48 PM

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

usr.bin/

grep/

19 lines

usr.bin/

grep/

17 lines

Diff 77704

contrib/netbsd-tests/usr.bin/grep/t_grep.sh

Loading...

usr.bin/grep/zgrep.sh

Loading...