Bruce noticed that xen_setbootenv wasn't defined anymore and after some
more digging I found that nothing in xenfunc.h was used anymore along
with most of amd64's xenvar.h.
Details
Details
Built all amd64, i386, and pc98 kernels via tinderbox.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
Thanks for the cleanup, I have a comment (more of a polite request actually ;)). If you don't feel like replacing the usages of vtomach you can commit this as-is, in any case it's better than what we had.
I've also realized we have some !xen_feature(XENFEAT_auto_translated_physmap) cases in netfront. Those should be removed, since now FreeBSD only supports running with an auto translated physmap.
sys/amd64/include/xen/xenvar.h | ||
---|---|---|
0 | Leaving this file only for the vtomach macro seems quite of a waste, we should replace the usage of vtomach with vtophys. |
Comment Actions
I've axed vtomach() as well when removing xenvar.h. After this is approved and goes in I can look at the auto_translated_physmap feature as a followup change.