Remove more vestiges of Xen PV domU.
ClosedPublic
Actions

Authored by jhb on Aug 1 2015, 5:47 AM.

Details

Reviewers

Commits

rS286372: Remove some more vestiges of the Xen PV domu support. Specifically,

Summary

Bruce noticed that xen_setbootenv wasn't defined anymore and after some
more digging I found that nothing in xenfunc.h was used anymore along
with most of amd64's xenvar.h.

Test Plan

Built all amd64, i386, and pc98 kernels via tinderbox.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

jhb updated this revision to Diff 7562.Aug 1 2015, 5:47 AM

jhb retitled this revision from to Remove more vestiges of Xen PV domU..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: royger.

jhb added a subscriber: kib.

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2015, 5:47 AM

Thanks for the cleanup, I have a comment (more of a polite request actually ;)). If you don't feel like replacing the usages of vtomach you can commit this as-is, in any case it's better than what we had.

I've also realized we have some !xen_feature(XENFEAT_auto_translated_physmap) cases in netfront. Those should be removed, since now FreeBSD only supports running with an auto translated physmap.

sys/amd64/include/xen/xenvar.h
34	Leaving this file only for the vtomach macro seems quite of a waste, we should replace the usage of vtomach with vtophys.

This revision is now accepted and ready to land.Aug 4 2015, 8:27 AM

Remove <machine/xenvar.h> entirely.

This revision now requires review to proceed.Aug 5 2015, 5:14 AM

Herald added a subscriber: asomers. · View Herald TranscriptAug 5 2015, 5:14 AM

I've axed vtomach() as well when removing xenvar.h. After this is approved and goes in I can look at the auto_translated_physmap feature as a followup change.

Closed by commit rS286372: Remove some more vestiges of the Xen PV domu support. Specifically, (authored by jhb). · Explain WhyAug 6 2015, 5:07 PM

This revision was automatically updated to reflect the committed changes.