Differential D26300

[unix(4) cleanup 7/8] Fix locking in uipc_accept().
ClosedPublic
Actions

Authored by markj on Sep 2 2020, 5:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 3:38 AM

	Unknown Object (File)
	Thu, Nov 14, 2:41 PM

	Unknown Object (File)
	Wed, Nov 6, 1:22 AM

	Unknown Object (File)
	Fri, Nov 1, 7:47 PM

	Unknown Object (File)
	Fri, Nov 1, 7:47 PM

	Unknown Object (File)
	Fri, Nov 1, 7:47 PM

	Unknown Object (File)
	Fri, Nov 1, 7:47 PM

	Unknown Object (File)
	Fri, Nov 1, 7:25 PM

View All 76 Files

Subscribers

Details

Reviewers: None
Commits: rS365765: Fix locking in uipc_accept().

Summary

This function wasn't converted to use the new locking protocol in
r333744. Make sure that it uses the PCB lock. Found by code
inspection.

Diff Detail

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/kern/uipc_usrreq.c:508	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 33338
Build 30649: arc lint + arc unit

Event Timeline

markj requested review of this revision.Sep 2 2020, 5:00 PM

markj created this revision.

Harbormaster completed remote builds in B33332: Diff 76546.Sep 2 2020, 5:00 PM

markj added a parent revision: D26299: [unix(4) cleanup 6/8] Simplify connection peer locking..Sep 2 2020, 5:09 PM

markj added a child revision: D26301: [unix(4) cleanup 8/8] Fix a double connect race..

emaste added a subscriber: emaste.Sep 2 2020, 5:20 PM

Use unp_pcb_unlock_pair().

Harbormaster completed remote builds in B33338: Diff 76552.Sep 2 2020, 6:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 15 2020, 7:24 PM

This revision was landed with ongoing or failed builds.

Closed by commit rS365765: Fix locking in uipc_accept(). (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS365765: Fix locking in uipc_accept()..

Herald added a subscriber: imp. · View Herald TranscriptSep 15 2020, 7:24 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

18 lines

Diff 76552

sys/kern/uipc_usrreq.c

Loading...