Page MenuHomeFreeBSD
Differential D26133

arm64/acpi: Give the real PA limit to ACPI
ClosedPublic
Actions

Authored by scottph on Aug 20 2020, 6:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 3:35 AM
Unknown Object (File)
Mon, Mar 10, 5:17 PM
Unknown Object (File)
Feb 25 2025, 5:05 AM
Unknown Object (File)
Feb 25 2025, 12:40 AM
Unknown Object (File)
Feb 24 2025, 7:06 PM
Unknown Object (File)
Feb 24 2025, 7:45 AM
Unknown Object (File)
Feb 22 2025, 5:32 AM
Unknown Object (File)
Jan 18 2025, 12:29 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
andrew
markj
manu
Commits
rS364797: arm64/acpi: Give the real PA limit to ACPI
Summary

Read PA bits from ID_AA64MMFR0_EL1.PARange.

MFC after: 1 week
Sponsored by: Ampere Computing, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

scottph created this revision.Aug 20 2020, 6:56 AM
Herald added a reviewer: manu. · View Herald TranscriptAug 20 2020, 6:56 AM
Herald added subscribers: emaste, imp. · View Herald Transcript
scottph requested review of this revision.Aug 20 2020, 6:56 AM
scottph mentioned this in D26134: arm64: Increase dmap size to 95 TiB.Aug 20 2020, 7:01 AM
andrew added a comment.Aug 20 2020, 7:49 AM

You should use get_kernel_reg to read the ID registers when we need a common version over all CPUs. It's not going to affect it here, but when use later in the boot it can as on a big.LITTLE system these ID registers can sometimes be different across the different core types.

sys/arm64/acpica/acpi_machdep.c
242

This should be ID_AA64MMFR0_PARange_VAL(mmfr0) Maybe with >> ID_AA64MMFR0_PARange_SHIFT, although the shift is 0 so it might be easier to add a comment to make this knowledge explicit.

scottph updated this revision to Diff 76051.Aug 21 2020, 7:36 AM
scottph marked an inline comment as done.
andrew accepted this revision.Aug 21 2020, 9:55 AM
This revision is now accepted and ready to land.Aug 21 2020, 9:55 AM
markj accepted this revision.Aug 23 2020, 6:57 PM
markj added inline comments.
sys/arm64/acpica/acpi_machdep.c
271

You might print the value itself in this message.

Closed by commit rS364797: arm64/acpi: Give the real PA limit to ACPI (authored by scottph). · Explain WhyAug 26 2020, 2:12 AM
This revision was automatically updated to reflect the committed changes.
scottph added a commit: rS364797: arm64/acpi: Give the real PA limit to ACPI.
ehem_freebsd_m5p.com mentioned this in D30297: arm64/nexus: use actual PA range for I/O memory limit.May 16 2021, 7:12 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
acpica/
37 lines
arm64/
7 lines

Diff 76051

View Options

sys/arm64/acpica/acpi_machdep.c

Show First 20 Lines • Show All 1,630 Lines • ▼ Show 20 Lines INP_WUNLOCK(in6p); \
{ {
struct ip6_pktopts **optp; struct ip6_pktopts **optp;
/* cannot mix with RFC2292 */ /* cannot mix with RFC2292 */
if (OPTBIT(IN6P_RFC2292)) { if (OPTBIT(IN6P_RFC2292)) {
error = EINVAL; error = EINVAL;
break; break;
} }
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(IPV6_HOPLIMIT, error = ip6_pcbopt(IPV6_HOPLIMIT,
(u_char *)&optval, sizeof(optval), (u_char *)&optval, sizeof(optval),
optp, (td != NULL) ? td->td_ucred : optp, (td != NULL) ? td->td_ucred :
NULL, uproto); NULL, uproto);
INP_WUNLOCK(in6p);
break; break;
} }
case IPV6_RECVHOPLIMIT: case IPV6_RECVHOPLIMIT:
OPTSET2292_EXCLUSIVE(IN6P_HOPLIMIT); OPTSET2292_EXCLUSIVE(IN6P_HOPLIMIT);
break; break;
case IPV6_RECVHOPOPTS: case IPV6_RECVHOPOPTS:
▲ Show 20 Lines • Show All 93 Lines • ▼ Show 20 Lines#endif
break; break;
} }
error = sooptcopyin(sopt, &optval, error = sooptcopyin(sopt, &optval,
sizeof optval, sizeof optval); sizeof optval, sizeof optval);
if (error) if (error)
break; break;
{ {
struct ip6_pktopts **optp; struct ip6_pktopts **optp;
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(optname, error = ip6_pcbopt(optname,
(u_char *)&optval, sizeof(optval), (u_char *)&optval, sizeof(optval),
optp, (td != NULL) ? td->td_ucred : optp, (td != NULL) ? td->td_ucred :
NULL, uproto); NULL, uproto);
INP_WUNLOCK(in6p);
break; break;
} }
case IPV6_2292PKTINFO: case IPV6_2292PKTINFO:
case IPV6_2292HOPLIMIT: case IPV6_2292HOPLIMIT:
case IPV6_2292HOPOPTS: case IPV6_2292HOPOPTS:
case IPV6_2292DSTOPTS: case IPV6_2292DSTOPTS:
case IPV6_2292RTHDR: case IPV6_2292RTHDR:
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines#endif
* later. * later.
*/ */
error = sooptcopyin(sopt, optbuf_storage, error = sooptcopyin(sopt, optbuf_storage,
sizeof(optbuf_storage), 0); sizeof(optbuf_storage), 0);
if (error) if (error)
break; break;
optlen = sopt->sopt_valsize; optlen = sopt->sopt_valsize;
optbuf = optbuf_storage; optbuf = optbuf_storage;
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(optname, optbuf, optlen, error = ip6_pcbopt(optname, optbuf, optlen,
optp, (td != NULL) ? td->td_ucred : NULL, optp, (td != NULL) ? td->td_ucred : NULL,
uproto); uproto);
INP_WUNLOCK(in6p);
break; break;
} }
#undef OPTSET #undef OPTSET
case IPV6_MULTICAST_IF: case IPV6_MULTICAST_IF:
case IPV6_MULTICAST_HOPS: case IPV6_MULTICAST_HOPS:
case IPV6_MULTICAST_LOOP: case IPV6_MULTICAST_LOOP:
case IPV6_JOIN_GROUP: case IPV6_JOIN_GROUP:
▲ Show 20 Lines • Show All 430 Lines • ▼ Show 20 Lines
static int static int
ip6_pcbopt(int optname, u_char *buf, int len, struct ip6_pktopts **pktopt, ip6_pcbopt(int optname, u_char *buf, int len, struct ip6_pktopts **pktopt,
struct ucred *cred, int uproto) struct ucred *cred, int uproto)
{ {
struct ip6_pktopts *opt; struct ip6_pktopts *opt;
if (*pktopt == NULL) { if (*pktopt == NULL) {
*pktopt = malloc(sizeof(struct ip6_pktopts), M_IP6OPT, *pktopt = malloc(sizeof(struct ip6_pktopts), M_IP6OPT,
M_WAITOK); M_NOWAIT);
if (*pktopt == NULL)
return (ENOBUFS);
ip6_initpktopts(*pktopt); ip6_initpktopts(*pktopt);
} }
opt = *pktopt; opt = *pktopt;
return (ip6_setpktopt(optname, buf, len, opt, cred, 1, 0, uproto)); return (ip6_setpktopt(optname, buf, len, opt, cred, 1, 0, uproto));
} }
#define GET_PKTOPT_VAR(field, lenexpr) do { \ #define GET_PKTOPT_VAR(field, lenexpr) do { \
▲ Show 20 Lines • Show All 810 Lines • Show Last 20 Lines
View Options

sys/arm64/arm64/identcpu.c

Show First 20 Lines • Show All 1,630 Lines • ▼ Show 20 Lines INP_WUNLOCK(in6p); \
{ {
struct ip6_pktopts **optp; struct ip6_pktopts **optp;
/* cannot mix with RFC2292 */ /* cannot mix with RFC2292 */
if (OPTBIT(IN6P_RFC2292)) { if (OPTBIT(IN6P_RFC2292)) {
error = EINVAL; error = EINVAL;
break; break;
} }
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(IPV6_HOPLIMIT, error = ip6_pcbopt(IPV6_HOPLIMIT,
(u_char *)&optval, sizeof(optval), (u_char *)&optval, sizeof(optval),
optp, (td != NULL) ? td->td_ucred : optp, (td != NULL) ? td->td_ucred :
NULL, uproto); NULL, uproto);
INP_WUNLOCK(in6p);
break; break;
} }
case IPV6_RECVHOPLIMIT: case IPV6_RECVHOPLIMIT:
OPTSET2292_EXCLUSIVE(IN6P_HOPLIMIT); OPTSET2292_EXCLUSIVE(IN6P_HOPLIMIT);
break; break;
case IPV6_RECVHOPOPTS: case IPV6_RECVHOPOPTS:
▲ Show 20 Lines • Show All 93 Lines • ▼ Show 20 Lines#endif
break; break;
} }
error = sooptcopyin(sopt, &optval, error = sooptcopyin(sopt, &optval,
sizeof optval, sizeof optval); sizeof optval, sizeof optval);
if (error) if (error)
break; break;
{ {
struct ip6_pktopts **optp; struct ip6_pktopts **optp;
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(optname, error = ip6_pcbopt(optname,
(u_char *)&optval, sizeof(optval), (u_char *)&optval, sizeof(optval),
optp, (td != NULL) ? td->td_ucred : optp, (td != NULL) ? td->td_ucred :
NULL, uproto); NULL, uproto);
INP_WUNLOCK(in6p);
break; break;
} }
case IPV6_2292PKTINFO: case IPV6_2292PKTINFO:
case IPV6_2292HOPLIMIT: case IPV6_2292HOPLIMIT:
case IPV6_2292HOPOPTS: case IPV6_2292HOPOPTS:
case IPV6_2292DSTOPTS: case IPV6_2292DSTOPTS:
case IPV6_2292RTHDR: case IPV6_2292RTHDR:
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines#endif
* later. * later.
*/ */
error = sooptcopyin(sopt, optbuf_storage, error = sooptcopyin(sopt, optbuf_storage,
sizeof(optbuf_storage), 0); sizeof(optbuf_storage), 0);
if (error) if (error)
break; break;
optlen = sopt->sopt_valsize; optlen = sopt->sopt_valsize;
optbuf = optbuf_storage; optbuf = optbuf_storage;
INP_WLOCK(in6p);
if (in6p->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(in6p);
return (ECONNRESET);
}
optp = &in6p->in6p_outputopts; optp = &in6p->in6p_outputopts;
error = ip6_pcbopt(optname, optbuf, optlen, error = ip6_pcbopt(optname, optbuf, optlen,
optp, (td != NULL) ? td->td_ucred : NULL, optp, (td != NULL) ? td->td_ucred : NULL,
uproto); uproto);
INP_WUNLOCK(in6p);
break; break;
} }
#undef OPTSET #undef OPTSET
case IPV6_MULTICAST_IF: case IPV6_MULTICAST_IF:
case IPV6_MULTICAST_HOPS: case IPV6_MULTICAST_HOPS:
case IPV6_MULTICAST_LOOP: case IPV6_MULTICAST_LOOP:
case IPV6_JOIN_GROUP: case IPV6_JOIN_GROUP:
▲ Show 20 Lines • Show All 430 Lines • ▼ Show 20 Lines
static int static int
ip6_pcbopt(int optname, u_char *buf, int len, struct ip6_pktopts **pktopt, ip6_pcbopt(int optname, u_char *buf, int len, struct ip6_pktopts **pktopt,
struct ucred *cred, int uproto) struct ucred *cred, int uproto)
{ {
struct ip6_pktopts *opt; struct ip6_pktopts *opt;
if (*pktopt == NULL) { if (*pktopt == NULL) {
*pktopt = malloc(sizeof(struct ip6_pktopts), M_IP6OPT, *pktopt = malloc(sizeof(struct ip6_pktopts), M_IP6OPT,
M_WAITOK); M_NOWAIT);
if (*pktopt == NULL)
return (ENOBUFS);
ip6_initpktopts(*pktopt); ip6_initpktopts(*pktopt);
} }
opt = *pktopt; opt = *pktopt;
return (ip6_setpktopt(optname, buf, len, opt, cred, 1, 0, uproto)); return (ip6_setpktopt(optname, buf, len, opt, cred, 1, 0, uproto));
} }
#define GET_PKTOPT_VAR(field, lenexpr) do { \ #define GET_PKTOPT_VAR(field, lenexpr) do { \
▲ Show 20 Lines • Show All 810 Lines • Show Last 20 Lines