Paths

Table of Contentst

gdb(4): Support empty qSupported queries
ClosedPublic
Actions

Authored by cem on Aug 18 2020, 7:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 15, 12:14 AM

	Unknown Object (File)
	Tue, Sep 15, 12:12 AM

	Unknown Object (File)
	Mon, Sep 14, 11:59 PM

	Unknown Object (File)
	Sat, Sep 5, 2:42 AM

	Unknown Object (File)
	Fri, Sep 4, 9:37 PM

	Unknown Object (File)
	Fri, Sep 4, 6:52 PM

	Unknown Object (File)
	Fri, Sep 4, 2:15 PM

	Unknown Object (File)
	Fri, Sep 4, 10:16 AM

View All Files

Subscribers

emaste

imp

Details

Reviewers

rlibby
markj
vangyzen
emaste

Commits

rS364358: gdb(4): Support empty qSupported queries

Summary

Technically a client may send a qSupported query without specifying any
client features. We should respond with our supported list in that case
instead of bailing with error.

Reported by: rlibby

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33058
Build 30441: arc lint + arc unit

Event Timeline

cem created this revision.Aug 18 2020, 7:57 PM

Herald added a subscriber: emaste. · View Herald TranscriptAug 18 2020, 7:57 PM

cem requested review of this revision.Aug 18 2020, 7:57 PM

Harbormaster completed remote builds in B33058: Diff 75971.Aug 18 2020, 7:57 PM

LGTM.

This revision is now accepted and ready to land.Aug 18 2020, 8:02 PM

vangyzen accepted this revision.Aug 18 2020, 8:03 PM

Fine with me. You could move the while loop into the case ':' block perhaps.

Closed by commit rS364358: gdb(4): Support empty qSupported queries (authored by cem). · Explain WhyAug 18 2020, 8:59 PM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS364358: gdb(4): Support empty qSupported queries.

Herald added a subscriber: imp. · View Herald TranscriptAug 18 2020, 8:59 PM

Revision Contents
Changeset List

Path

Size

sys/

gdb/

gdb_main.c

9 lines

Diff 75971

View Options

gdb(4): Support empty qSupported queriesClosedPublicActions