Differential D26034

zfs: fix EIO accessing dataset after resuming interrupted receive
ClosedPublic
Actions

Authored by asomers on Aug 11 2020, 8:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 25, 7:14 PM

	Unknown Object (File)
	Tue, Apr 21, 2:30 AM

	Unknown Object (File)
	Tue, Apr 14, 10:21 AM

	Unknown Object (File)
	Tue, Apr 14, 6:29 AM

	Unknown Object (File)
	Tue, Apr 14, 12:05 AM

	Unknown Object (File)
	Mon, Apr 13, 8:27 PM

	Unknown Object (File)
	Sat, Apr 11, 12:45 AM

	Unknown Object (File)
	Fri, Apr 10, 8:37 AM

Subscribers

Details

Reviewers

freqlabs
avg
mmacy

Commits

rS364978: MFC r364412:
rS364974: MFC r364412:
rS364412: zfs: fix EIO accessing dataset after resuming interrupted receive

Summary

zfs: fix EIO accessing dataset after resuming interrupted receive

ZFS unmounts a dataset while receiving into it and remounts it afterwards.
But if ZFS is resuming an incomplete receive, it screws up and ends up with
a dataset that is mounted, but returns EIO for every access. This commit
fixes that condition.

While the vulnerable code also exists in OpenZFS, the problem is not
reproducible there. Apparently OpenZFS doesn't unmount the destination
dataset during receive, like FreeBSD does.

PR: 248606

Test Plan

ZFS test suite, plus instructions attached to PR

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 32927
Build 30325: arc lint + arc unit

Event Timeline

asomers created this revision.Aug 11 2020, 8:36 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptAug 11 2020, 8:36 PM

asomers requested review of this revision.Aug 11 2020, 8:36 PM

Harbormaster completed remote builds in B32927: Diff 75701.Aug 11 2020, 8:36 PM

ping. Any comments here? I'd like to commit before 12.2-RELEASE if possible.

LGTM

This revision is now accepted and ready to land.Aug 20 2020, 1:17 AM

In D26034#580088, @mmacy wrote:

LGTM

Thanks Matt.

Closed by commit rS364412: zfs: fix EIO accessing dataset after resuming interrupted receive (authored by asomers). · Explain WhyAug 20 2020, 1:31 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS364412: zfs: fix EIO accessing dataset after resuming interrupted receive.

asomers added a commit: rS364974: MFC r364412:.Aug 30 2020, 4:28 PM

asomers added a commit: rS364978: MFC r364412:.Aug 30 2020, 6:22 PM

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libzfs/

common/

libzfs_sendrecv.c

2 lines

Diff 75701

cddl/contrib/opensolaris/lib/libzfs/common/libzfs_sendrecv.c

Loading...