Differential D25985

Allow linking the kernel with a linker that doesn't support -z ifunc-noplt
ClosedPublic
Actions

Authored by arichardson on Aug 7 2020, 11:21 AM.

Tags

None

Referenced Files

	F86143032: D25985.id75688.diff
	Sun, Jun 16, 1:56 AM

	F86142910: D25985.id75550.diff
	Sun, Jun 16, 1:53 AM

	Unknown Object (File)
	Fri, May 24, 4:09 AM

	Unknown Object (File)
	Mon, May 20, 12:59 AM

	Unknown Object (File)
	Mon, May 20, 12:59 AM

	Unknown Object (File)
	Sun, May 19, 9:24 PM

	Unknown Object (File)
	Sun, May 19, 9:24 PM

	Unknown Object (File)
	Sun, May 19, 7:34 PM

View All 28 Files

Subscribers

Details

Reviewers

markj
dim
emaste
bdrewery

Commits

rS364125: Allow linking the kernel with a linker that doesn't support -z ifunc-noplt

Summary

This can happen when linking with upstream LLD < 9.0.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Aug 7 2020, 11:21 AM

Herald added a subscriber: bdrewery. · View Herald TranscriptAug 7 2020, 11:21 AM

arichardson requested review of this revision.Aug 7 2020, 11:21 AM

Harbormaster completed remote builds in B32832: Diff 75550.Aug 7 2020, 11:21 AM

arichardson added inline comments.Aug 7 2020, 11:24 AM

share/mk/bsd.linker.mk
98 ↗	(On Diff #75550)	Could probably drop the LINKER_FREEBSD_VERSION check if we assume that all lld's older than 9.0 build from the source tree have the patch applied.

arichardson added a reviewer: bdrewery.Aug 7 2020, 11:25 AM

markj added inline comments.Aug 7 2020, 1:47 PM

share/mk/bsd.linker.mk
98 ↗	(On Diff #75550)	Where does the comparison with 1300000 come from?
sys/conf/kern.pre.mk
170 ↗	(On Diff #75550)	I would tone down the warning a bit, it's not a major optimization. Maybe something like, "ifunc calls are unoptimized".

arichardson added inline comments.Aug 7 2020, 2:32 PM

share/mk/bsd.linker.mk
98 ↗	(On Diff #75550)	I believe the patch was added after 13 branched? Although it looks like I have an additional zero there.
sys/conf/kern.pre.mk
170 ↗	(On Diff #75550)	will do in next version

drop LINKER_FREEBSD_VERSION check, checking for lld > 9.0 is enough
change warning message

Harbormaster completed remote builds in B32912: Diff 75677.Aug 11 2020, 3:06 PM

markj accepted this revision.Aug 11 2020, 3:18 PM

This revision is now accepted and ready to land.Aug 11 2020, 3:18 PM

Closed by commit rS364125: Allow linking the kernel with a linker that doesn't support -z ifunc-noplt (authored by arichardson). · Explain WhyAug 11 2020, 4:47 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS364125: Allow linking the kernel with a linker that doesn't support -z ifunc-noplt.

Herald added a subscriber: imp. · View Herald TranscriptAug 11 2020, 4:47 PM

Revision Contents
Changeset List

Path

Size

head/

share/

mk/

3 lines

sys/

conf/

4 lines

Diff 75688

head/share/mk/bsd.linker.mk

Loading...

head/sys/conf/kern.pre.mk

Loading...