Remove redeclaration found by gcc build
ClosedPublic
Actions

Authored by lwhsu on Aug 5 2020, 5:26 AM.

Details

Reviewers

erj
jhb

Group Reviewers

Intel Networking

Commits

rS364240: Remove redeclaration found by gcc build

Summary

Remove redeclaration found by gcc build

These functions are also in ice_osdep.h and ice_nvm.h, where seems to be more
suitable.

Test Plan

Build with gcc and clang.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32763
Build 30198: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Aug 5 2020, 5:26 AM

lwhsu created this revision.

Harbormaster completed remote builds in B32763: Diff 75407.Aug 5 2020, 5:26 AM

lwhsu added a reviewer: Intel Networking.Aug 5 2020, 5:26 AM

ping?

The latter nvm related functions can be removed immediately; these have been removed in a newer version of the driver.

ice_free_list() doesn't even appear to be defined, and I think it is ok to have the other functions declared/defined in ice_osdep.h instead of ice_common.h.

I'm not sure why they are there in ice_common.h.

@jacob.e.keller_intel.com do you maybe have any thoughts on this, too?

This revision is now accepted and ready to land.Aug 10 2020, 10:29 PM

Closed by commit rS364240: Remove redeclaration found by gcc build (authored by lwhsu). · Explain WhyAug 15 2020, 3:21 AM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rS364240: Remove redeclaration found by gcc build.

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2020, 3:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ice/

ice_common.h

17 lines

Diff 75407

View Options

Remove redeclaration found by gcc buildClosedPublicActions