ip6_output(): Check the return value of in6_getlinkifnet().
ClosedPublic
Actions

Authored by markj on Jul 30 2020, 12:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 27, 6:13 AM

	Unknown Object (File)
	Thu, Mar 26, 10:16 PM

	Unknown Object (File)
	Tue, Mar 24, 5:03 AM

	Unknown Object (File)
	Mon, Mar 23, 10:07 PM

	Unknown Object (File)
	Thu, Mar 19, 10:28 AM

	Unknown Object (File)
	Thu, Mar 19, 3:03 AM

	Unknown Object (File)
	Wed, Mar 18, 8:45 PM

	Unknown Object (File)
	Dec 28 2025, 4:42 AM

View All 90 Files

Subscribers

imp

melifaro

Details

Reviewers

melifaro
ae
bz
tuexen

Commits

rS363710: ip6_output(): Check the return value of in6_getlinkifnet().

Summary

If the destination address has an embedded scope ID, make sure that it
corresponds to a valid ifnet before proceeding. Otherwise a sendto()
with a bogus link-local address can trigger a NULL pointer dereference.

Reported by: syzkaller

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32652
Build 30104: arc lint + arc unit

Event Timeline

markj created this revision.Jul 30 2020, 12:46 AM

Herald added subscribers: melifaro, ae. · View Herald TranscriptJul 30 2020, 12:46 AM

markj requested review of this revision.Jul 30 2020, 12:46 AM

Harbormaster completed remote builds in B32652: Diff 75151.Jul 30 2020, 12:46 AM

markj added reviewers: melifaro, ae, bz, tuexen.Jul 30 2020, 12:47 AM

LGTM.

This revision is now accepted and ready to land.Jul 30 2020, 7:45 AM

Closed by commit rS363710: ip6_output(): Check the return value of in6_getlinkifnet(). (authored by markj). · Explain WhyJul 30 2020, 5:43 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS363710: ip6_output(): Check the return value of in6_getlinkifnet()..

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2020, 5:43 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

ip6_output.c

4 lines

Diff 75151

View Options

ip6_output(): Check the return value of in6_getlinkifnet().ClosedPublicActions