Differential D25807

Change DMAR sysctl node
ClosedPublic
Actions

Authored by br on Jul 25 2020, 7:59 PM.

Details

Reviewers

kib

Commits

rS363534: o Make the _hw_iommu sysctl node non-static;

Summary

Change all _hw_dmar to _hw_iommu

Test Plan

Boot on amd64

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br requested review of this revision.Jul 25 2020, 7:59 PM

br created this revision.

kib added inline comments.Jul 25 2020, 8:29 PM

sys/dev/iommu/iommu_gas.c
737–738	Mmm, I think the node should be declared unconditionally, regardless of the INVARIANTS build. Also I remember that nodes should be RW if any mib below them is rw.
sys/x86/iommu/intel_utils.c
658–660	This should not link in non-INVARIANTS kernels. Also, I asked to put dmar-specific mibs under hw.iommu.dmar.

o _hw_iommu is RW
o _hw_iommu is declared regardless INVARIANTS support
o dmar sysctl options are under _hw_iommu_dmar, not _hw_iommu
o _hw_iommu_dmar are all INVARIANTS only

sys/dev/iommu/iommu_gas.c
737–738	All fixed. sorry

kib added inline comments.Jul 25 2020, 9:08 PM

sys/dev/iommu/iommu_gas.c
738	This one should be under INVARIANTS indeed.
sys/x86/iommu/intel_utils.c
670	None of these sysctls should be under INVARIANTS. They are all either informational or knobs to tune performance.

sysctl knobs present in all kernels, regardless of INVARIANTS

br added inline comments.Jul 25 2020, 9:26 PM

sys/x86/iommu/intel_utils.c
658–660	what do you mean that it should not link (in non-invariants kernel) ?

kib accepted this revision.Jul 25 2020, 9:28 PM

This revision is now accepted and ready to land.Jul 25 2020, 9:28 PM

kib added inline comments.Jul 25 2020, 9:34 PM

sys/x86/iommu/intel_utils.c
658–660	I mean that for non-INVARIANTS kernels the node (or whatever, I do not remember already) was defined only under INVARIANTS (i.e. nowhere), while declared and used. Then linker should compain about undefined symbol.