Change all _hw_dmar to _hw_iommu
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
sys/dev/iommu/iommu_gas.c | ||
---|---|---|
736 | Mmm, I think the node should be declared unconditionally, regardless of the INVARIANTS build. Also I remember that nodes should be RW if any mib below them is rw. | |
sys/x86/iommu/intel_utils.c | ||
658 | This should not link in non-INVARIANTS kernels. Also, I asked to put dmar-specific mibs under hw.iommu.dmar. |
Comment Actions
o _hw_iommu is RW
o _hw_iommu is declared regardless INVARIANTS support
o dmar sysctl options are under _hw_iommu_dmar, not _hw_iommu
o _hw_iommu_dmar are all INVARIANTS only
sys/dev/iommu/iommu_gas.c | ||
---|---|---|
736 | All fixed. sorry |
sys/x86/iommu/intel_utils.c | ||
---|---|---|
658 | what do you mean that it should not link (in non-invariants kernel) ? |
sys/x86/iommu/intel_utils.c | ||
---|---|---|
658 | I mean that for non-INVARIANTS kernels the node (or whatever, I do not remember already) was defined only under INVARIANTS (i.e. nowhere), while declared and used. Then linker should compain about undefined symbol. |