Fix L2CAP ACL packet Packet Boundary flag for LE packet.
ClosedPublic
Actions

Authored by takawata on Jul 17 2020, 10:41 AM.

Details

Reviewers

emax
val_packett.cool

Commits

rS363276: Fix L2CAP ACL packet PB(Packet Boundary) flag for LE PDU.

Summary

ACL packet boundary flag should be 0 instead of 2 for LE packet.
Some HCI will ignore LE packet with PB flag is 2, which will prevent
packet from sending.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32377
Build 29858: arc lint + arc unit

Event Timeline

takawata created this revision.Jul 17 2020, 10:41 AM

Herald added subscribers: melifaro, donner, imp. · View Herald TranscriptJul 17 2020, 10:41 AM

Harbormaster completed remote builds in B32377: Diff 74566.Jul 17 2020, 10:41 AM

takawata requested review of this revision.Jul 17 2020, 10:41 AM

It's a bit funny that the check is == NG_HCI_LINK_ACL (we are speaking ACL anyway), but makes sense — with LE it would be NG_HCI_LINK_LE_PUBLIC / NG_HCI_LINK_LE_RANDOM, and others like SCO wouldn't be used with L2CAP (?)

This revision is now accepted and ready to land.Jul 17 2020, 11:53 AM

emax accepted this revision.Jul 17 2020, 3:06 PM

Closed by commit rS363276: Fix L2CAP ACL packet PB(Packet Boundary) flag for LE PDU. (authored by takawata). · Explain WhyJul 17 2020, 3:50 PM

This revision was automatically updated to reflect the committed changes.

takawata added a commit: rS363276: Fix L2CAP ACL packet PB(Packet Boundary) flag for LE PDU..