Differential D25654

Use PVO_PADDR to get the PA from PVO
ClosedPublic
Actions

Authored by luporl on Jul 13 2020, 8:03 PM.

Details

Reviewers

markj

Group Reviewers

PowerPC

Commits

rS363222: [PowerPC] Use PVO_PADDR to get the PA from PVO

Summary

Use PVO_PADDR macro to get the physical address from a PVO, instead of explicitly ANDing pvo_pte.pa with LPTE_RPGN where it is needed.
Besides improving readability, this is needed to support superpages (D25237), where the steps to get the PA from a PVO are different.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

luporl created this revision.Jul 13 2020, 8:03 PM

Herald added subscribers: alfredo, bdragon, jhibbits. · View Herald TranscriptJul 13 2020, 8:03 PM

luporl requested review of this revision.Jul 13 2020, 8:03 PM

Harbormaster completed remote builds in B32300: Diff 74416.Jul 13 2020, 8:03 PM

luporl mentioned this in D25237: Implement superpages for PowerPC64 (HPT).Jul 13 2020, 8:13 PM

luporl added a child revision: D25237: Implement superpages for PowerPC64 (HPT).

markj accepted this revision.Jul 13 2020, 8:31 PM

This revision is now accepted and ready to land.Jul 13 2020, 8:31 PM

Closed by commit rS363222: [PowerPC] Use PVO_PADDR to get the PA from PVO (authored by luporl). · Explain WhyJul 15 2020, 1:44 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS363222: [PowerPC] Use PVO_PADDR to get the PA from PVO.

Herald added a subscriber: imp. · View Herald TranscriptJul 15 2020, 1:44 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

aim/

mmu_oea64.c

31 lines

Diff 74484

View Options

head/sys/powerpc/aim/mmu_oea64.c

	Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Lines

	SYSCTL_NODE(_security, OID_AUTO, bsd, CTLFLAG_RW \| CTLFLAG_MPSAFE, 0,			SYSCTL_NODE(_security, OID_AUTO, bsd, CTLFLAG_RW \| CTLFLAG_MPSAFE, 0,
	"BSD security policy");			"BSD security policy");

	static void crfree_final(struct ucred *cr);			static void crfree_final(struct ucred *cr);
	static void crsetgroups_locked(struct ucred *cr, int ngrp,			static void crsetgroups_locked(struct ucred *cr, int ngrp,
	gid_t *groups);			gid_t *groups);

				static int cr_canseeotheruids(struct ucred u1, struct ucred u2);
				static int cr_canseeothergids(struct ucred u1, struct ucred u2);
				static int cr_canseejailproc(struct ucred u1, struct ucred u2);

	#ifndef _SYS_SYSPROTO_H_			#ifndef _SYS_SYSPROTO_H_
	struct getpid_args {			struct getpid_args {
	int dummy;			int dummy;
	};			};
	#endif			#endif
	/* ARGSUSED */			/* ARGSUSED */
	int			int
	sys_getpid(struct thread td, struct getpid_args uap)			sys_getpid(struct thread td, struct getpid_args uap)
	▲ Show 20 Lines • Show All 1,246 Lines • ▼ Show 20 Lines
	/*-			/*-
	* Determine if u1 "can see" the subject specified by u2, according to the			* Determine if u1 "can see" the subject specified by u2, according to the
	* 'see_other_uids' policy.			* 'see_other_uids' policy.
	* Returns: 0 for permitted, ESRCH otherwise			* Returns: 0 for permitted, ESRCH otherwise
	* Locks: none			* Locks: none
	* References: u1 and u2 must not change during the call			* References: u1 and u2 must not change during the call
	* u1 may equal u2, in which case only one reference is required			* u1 may equal u2, in which case only one reference is required
	*/			*/
	int			static int
	cr_canseeotheruids(struct ucred u1, struct ucred u2)			cr_canseeotheruids(struct ucred u1, struct ucred u2)
	{			{

	if (!see_other_uids && u1->cr_ruid != u2->cr_ruid) {			if (!see_other_uids && u1->cr_ruid != u2->cr_ruid) {
	if (priv_check_cred(u1, PRIV_SEEOTHERUIDS) != 0)			if (priv_check_cred(u1, PRIV_SEEOTHERUIDS) != 0)
	return (ESRCH);			return (ESRCH);
	}			}
	return (0);			return (0);
	Show All 13 Lines
	/*			/*
	* Determine if u1 can "see" the subject specified by u2, according to the			* Determine if u1 can "see" the subject specified by u2, according to the
	* 'see_other_gids' policy.			* 'see_other_gids' policy.
	* Returns: 0 for permitted, ESRCH otherwise			* Returns: 0 for permitted, ESRCH otherwise
	* Locks: none			* Locks: none
	* References: u1 and u2 must not change during the call			* References: u1 and u2 must not change during the call
	* u1 may equal u2, in which case only one reference is required			* u1 may equal u2, in which case only one reference is required
	*/			*/
	int			static int
	cr_canseeothergids(struct ucred u1, struct ucred u2)			cr_canseeothergids(struct ucred u1, struct ucred u2)
	{			{
	int i, match;			int i, match;

	if (!see_other_gids) {			if (!see_other_gids) {
	match = 0;			match = 0;
	for (i = 0; i < u1->cr_ngroups; i++) {			for (i = 0; i < u1->cr_ngroups; i++) {
	if (groupmember(u1->cr_groups[i], u2))			if (groupmember(u1->cr_groups[i], u2))
	Show All 25 Lines
	/*-			/*-
	* Determine if u1 "can see" the subject specified by u2, according to the			* Determine if u1 "can see" the subject specified by u2, according to the
	* 'see_jail_proc' policy.			* 'see_jail_proc' policy.
	* Returns: 0 for permitted, ESRCH otherwise			* Returns: 0 for permitted, ESRCH otherwise
	* Locks: none			* Locks: none
	* References: u1 and u2 must not change during the call			* References: u1 and u2 must not change during the call
	* u1 may equal u2, in which case only one reference is required			* u1 may equal u2, in which case only one reference is required
	*/			*/
	int			static int
	cr_canseejailproc(struct ucred u1, struct ucred u2)			cr_canseejailproc(struct ucred u1, struct ucred u2)
	{			{
	return (see_jail_proc != 0 \|\| u1->cr_prison == u2->cr_prison \|\|			return (see_jail_proc != 0 \|\| u1->cr_prison == u2->cr_prison \|\|
	priv_check_cred(u1, PRIV_SEEJAILPROC) == 0 ?			priv_check_cred(u1, PRIV_SEEJAILPROC) == 0 ?
	0 : ESRCH);			0 : ESRCH);
	}			}


	▲ Show 20 Lines • Show All 1,075 Lines • Show Last 20 Lines

Use PVO_PADDR to get the PA from PVOClosedPublicActions