Page MenuHomeFreeBSD

Make linux(4) support splice(2) - kind of
ClosedPublic

Authored by trasz on Jul 12 2020, 3:24 PM.
Tags
None
Referenced Files
F136981623: D25636.id.diff
Thu, Nov 20, 9:57 PM
F136981606: D25636.id74359.diff
Thu, Nov 20, 9:57 PM
F136981602: D25636.id74361.diff
Thu, Nov 20, 9:57 PM
F136981390: D25636.id74614.diff
Thu, Nov 20, 9:56 PM
F136981375: D25636.id74360.diff
Thu, Nov 20, 9:56 PM
F136979177: D25636.diff
Thu, Nov 20, 9:47 PM
Unknown Object (File)
Sun, Nov 16, 1:56 PM
Unknown Object (File)
Sun, Nov 16, 10:47 AM
Subscribers

Details

Summary

Add a trivial linux(4) splice(2) implementation, which simply
returns EINVAL. Fixes grep (grep-3.1-2build1).

PR: kern/247219

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32278
Build 29762: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Jul 12 2020, 3:24 PM
sys/compat/linux/linux_file.c
1774

so consumers handle EINVAL from splice but not ENOSYS?

sys/compat/linux/linux_file.c
1774

Precisely. Well, the one I found: grep. But looking at splice(2) man page, consumers probably need to handle it anyway: with early kernels exactly one of the fds had to be a pipe, later both could be, then there's "EINVAL The target filesystem doesn't support splicing"...

Probably worth putting that EINVAL description in a comment by the return.

This revision is now accepted and ready to land.Jul 14 2020, 12:58 AM