Differential D25516

Allow some Bluetooth LE related HCI request by non-root user.
ClosedPublic
Actions

Authored by takawata on Jun 30 2020, 4:24 AM.

Tags

None

Referenced Files

	F168399157: D25516.id73898.diff
	Fri, Aug 28, 1:09 AM

	F168399156: D25516.id73943.diff
	Fri, Aug 28, 1:09 AM

	F168383225: D25516.id.diff
	Thu, Aug 27, 9:57 PM

	Unknown Object (File)
	Thu, Aug 27, 8:20 AM

	Unknown Object (File)
	Wed, Aug 26, 4:03 PM

	Unknown Object (File)
	Tue, Aug 25, 2:54 AM

	Unknown Object (File)
	Fri, Aug 21, 3:12 AM

	Unknown Object (File)
	Thu, Aug 20, 10:41 AM

Subscribers

val_packett.cool

Details

Reviewers

Commits

rS362825: Allow some Bluetooth LE related HCI request to non-root user.

Summary

Now Bluetooth LE related requests are not allowed by non-root user.
This patch allow request as follows:
NG_HCI_OCF_READ_LE_HOST_SUPPORTED
NG_HCI_OCF_LE_SET_SCAN_ENABLE
NG_HCI_OCF_LE_SET_SCAN_PARAMETERS
NG_HCI_OCF_LE_READ_LOCAL_SUPPORTED_FEATURES
NG_HCI_OCF_LE_READ_BUFFER_SIZE
NG_HCI_OCF_LE_READ_WHITE_LIST_SIZE

Test Plan

% hccontrol read_le_host_support
% hccontrol le_set_scan_enable enable
% hccontrol le_set_scan_enable disable
% hccontrol le_read_local_supported features
% hccontrol le_read_buffer_size
% hccontrol le_read_white_list_size

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32055
Build 29580: arc lint + arc unit

Event Timeline

takawata created this revision.Jun 30 2020, 4:24 AM

Herald added subscribers: melifaro, donner, imp. · View Herald TranscriptJun 30 2020, 4:24 AM

takawata requested review of this revision.Jun 30 2020, 4:24 AM

Harbormaster completed remote builds in B32055: Diff 73898.Jun 30 2020, 4:24 AM

takawata added a reviewer: emax.Jun 30 2020, 8:33 AM

From the netgraph part, there is no objection.

emax accepted this revision.Jun 30 2020, 5:20 PM

This revision is now accepted and ready to land.Jun 30 2020, 5:20 PM

val_packett.cool added a subscriber: val_packett.cool.Jun 30 2020, 5:29 PM

Closed by commit rS362825: Allow some Bluetooth LE related HCI request to non-root user. (authored by takawata). · Explain WhyJul 1 2020, 4:01 AM

This revision was automatically updated to reflect the committed changes.

takawata added a commit: rS362825: Allow some Bluetooth LE related HCI request to non-root user..

Revision Contents
Changeset List

Path

Size

sys/

netgraph/

bluetooth/

socket/

ng_btsocket_hci_raw.c

6 lines

Diff 73898

sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c

Loading...