Page MenuHomeFreeBSD
Differential D25427

Add WITH_CLANG_FORMAT option
ClosedPublic
Actions

Authored by cem on Jun 24 2020, 4:32 PM.
Tags
None
Referenced Files
F168651261: D25427.id73584.diff
Sat, Aug 29, 10:54 AM
F168641784: D25427.id.diff
Sat, Aug 29, 9:52 AM
F168493300: D25427.diff
Fri, Aug 28, 4:27 PM
Unknown Object (File)
Fri, Aug 28, 1:16 PM
Unknown Object (File)
Fri, Aug 28, 1:15 PM
Unknown Object (File)
Fri, Aug 28, 12:36 PM
Unknown Object (File)
Wed, Aug 26, 9:54 PM
Unknown Object (File)
Wed, Aug 26, 9:43 PM
View All Files
Subscribers
bdrewery
dim
imp

Details

Reviewers
emaste
Commits
rS362587: Add WITH_CLANG_FORMAT option
Summary

clang-format is enabled conditional on either WITH_CLANG_EXTRAS or
WITH_CLANG_FORMAT. Some sources in libclang are build conditional on
either rule, and obviously the clang-format binary itself depends on the
rule.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31925
Build 29476: arc lint + arc unit

Event Timeline

cem created this revision.Jun 24 2020, 4:32 PM
Herald added a subscriber: bdrewery. · View Herald TranscriptJun 24 2020, 4:32 PM
cem requested review of this revision.Jun 24 2020, 4:32 PM
Harbormaster completed remote builds in B31924: Diff 73580.Jun 24 2020, 4:32 PM
emaste accepted this revision.Jun 24 2020, 4:35 PM
emaste added a subscriber: dim.

LGTM

lib/clang/libclang/Makefile
25

EXTRAS || FORMAT for alpha order?

This revision is now accepted and ready to land.Jun 24 2020, 4:36 PM
emaste added a comment.Jun 24 2020, 4:36 PM

Also add a WITH_CLANG_FORMAT text description file

cem updated this revision to Diff 73581.Jun 24 2020, 4:39 PM
cem marked an inline comment as done.

Reorder EXTRAS, FORMAT

Add WITH_CLANG_FORMAT file

This revision now requires review to proceed.Jun 24 2020, 4:39 PM
Harbormaster completed remote builds in B31925: Diff 73581.Jun 24 2020, 4:39 PM
emaste accepted this revision.Jun 24 2020, 4:48 PM
This revision is now accepted and ready to land.Jun 24 2020, 4:48 PM
Closed by commit rS362587: Add WITH_CLANG_FORMAT option (authored by cem). · Explain WhyJun 24 2020, 5:03 PM
This revision was automatically updated to reflect the committed changes.
cem added a commit: rS362587: Add WITH_CLANG_FORMAT option.
Herald added a subscriber: imp. · View Herald TranscriptJun 24 2020, 5:03 PM
dim mentioned this in rS363494: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.Jul 24 2020, 8:48 PM
dim mentioned this in rS363496: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.Jul 24 2020, 8:54 PM

Revision Contents
Changeset List

PathSize
5 lines
lib/
clang/
libclang/
4 lines
share/
mk/
2 lines
targets/
pseudo/
bootstrap-tools/
2 lines
clang/
5 lines
tools/
build/
mk/
5 lines
options/
2 lines
usr.bin/
clang/
5 lines

Diff 73581

View Options

Makefile.inc1

Loading...
View Options

lib/clang/libclang/Makefile

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

targets/pseudo/bootstrap-tools/Makefile

Loading...
View Options

targets/pseudo/clang/Makefile.depend

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...
View Options

tools/build/options/WITH_CLANG_FORMAT

Loading...
View Options

usr.bin/clang/Makefile

Loading...