Page MenuHomeFreeBSD
Differential D25274

Add iMX8MQ support
ClosedPublic
Actions

Authored by gonzo on Jun 14 2020, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 27, 10:49 PM
Unknown Object (File)
Mon, Oct 27, 8:25 PM
Unknown Object (File)
Sat, Oct 25, 11:49 PM
Unknown Object (File)
Thu, Oct 23, 3:16 AM
Unknown Object (File)
Sun, Oct 19, 11:00 PM
Unknown Object (File)
Sun, Oct 19, 11:00 PM
Unknown Object (File)
Sun, Oct 19, 10:59 PM
Unknown Object (File)
Sun, Oct 19, 10:59 PM
View All Files
Subscribers
andrew
emaste
imp
loos

Details

Reviewers
• ian
manu
Commits
rS362817: Add i.MX 8M Quad support
Summary

This patch adds basic support for for iMX8:

  • CCM driver and clocks implementations for iMX8
  • GPC driver for iMX8
  • clock tree for iMX8MQ
  • clocks support and new compat strings (if required) for existing iMX6 UART, I2C, and GPIO drivers
  • Enables aarch64-compatible drivers form iMX6 to arm64 GENERIC kernel config
  • dtb/imx8 kernel module with DTBs for Nitrogen8M and iMX8MQ EVK
Test Plan

This patch was tested only for basic functionality:

  • Booted on Nitrogen8M board with NFS root
  • Booted on iMX8MQ EVK board with NFS root
  • watchdog tested with watchdogd -t 33 -e /usr/bin/false --debug
  • I2C tested by scanning the bus and checking that there is device
  • GPIO wasn't tested

Also verified that both GENERIC and IMX6 kernel configs still build
and boot with this patch applied.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31740
Build 29307: arc lint + arc unit

Event Timeline

gonzo created this revision.Jun 14 2020, 11:40 PM
Herald added subscribers: loos, emaste, andrew. · View Herald TranscriptJun 14 2020, 11:40 PM
Harbormaster completed remote builds in B31705: Diff 73120.Jun 14 2020, 11:40 PM
gonzo requested review of this revision.Jun 14 2020, 11:40 PM
manu added a comment.Jun 16 2020, 5:09 PM

Added a few nits but otherwise it's looks great, thanks for working on this !

sys/arm/freescale/imx/imx_wdog.c
170 ↗(On Diff #73120)

I guess this could be commited separatly.

sys/arm64/conf/GENERIC
116

How different are the IMX8 SoCs ?
Maybe we just need SOC_FREESCALE_IMX8 as I guess all the drivers are more or less the same and only a few clocks/device will be present or not.

sys/arm64/freescale/imx/clk/imx_clk_sscg_pll.c
152

This can be move above the divr1 = ... line I suppose.

sys/arm64/freescale/imx/imx7gpc.c
6

Do you want the "all rights reserved" mention ?

10

Where does that comes from ?

sys/arm64/freescale/imx/imx8mq_ccm.c
57

It's unfortunately GPLv2 licenced ...
What we did for rockchip is that we redefined those value.
I agree that this file cannot be licenced as it's just name/id representation but ...

62

Does the dummy clocks represent some unimplemented clocks or is it needed because the parent idx is 2 bits ?

sys/arm64/freescale/imx/imx_ccm_clk.h
6

Same comment as above for this mention.

sys/modules/dtb/imx8/Makefile
3

s/imx6/imx8/

gonzo marked 9 inline comments as done.Jun 16 2020, 7:37 PM
gonzo added inline comments.
sys/arm64/conf/GENERIC
116

Yes, looks like the difference is mostly in set of blocks in the SoC, but overall they're conceptually the same: https://www.nxp.com/docs/en/supporting-information/IMX8LAYERCMPR.pdf

sys/arm64/freescale/imx/imx7gpc.c
10

I started by using arm/freescale/imx/imx_gpt.c but ended up completely rewriting it, so will remove it.

sys/arm64/freescale/imx/imx8mq_ccm.c
62

The latter I think. There is dummy clock id in the header file: IMX8MQ_CLK_DUMMY

gonzo updated this revision to Diff 73181.Jun 16 2020, 7:38 PM
gonzo marked 3 inline comments as done.

Address manu@ comments

Harbormaster completed remote builds in B31740: Diff 73181.Jun 16 2020, 7:38 PM
manu accepted this revision.Jun 16 2020, 7:43 PM
This revision is now accepted and ready to land.Jun 16 2020, 7:43 PM
Closed by commit rS362817: Add i.MX 8M Quad support (authored by gonzo). · Explain WhyJul 1 2020, 12:33 AM
This revision was automatically updated to reflect the committed changes.
gonzo added a commit: rS362817: Add i.MX 8M Quad support.
Herald added a subscriber: imp. · View Herald TranscriptJul 1 2020, 12:33 AM

Revision Contents
Changeset List

PathSize
sys/
arm/
freescale/
imx/
47 lines
46 lines
1 line
arm64/
conf/
6 lines
freescale/
imx/
clk/
45 lines
309 lines
42 lines
177 lines
45 lines
117 lines
45 lines
138 lines
42 lines
195 lines
263 lines
173 lines
484 lines
212 lines
conf/
1 line
15 lines
1 line
dev/
ffec/
1 line
uart/
61 lines
modules/
dtb/
imx8/
7 lines

Diff 73181

View Options

sys/arm/freescale/imx/imx_gpio.c

Loading...
View Options

sys/arm/freescale/imx/imx_i2c.c

Loading...
View Options

sys/arm/freescale/imx/imx_iomux.c

Loading...
View Options

sys/arm64/conf/GENERIC

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_composite.h

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_composite.c

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_frac_pll.h

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_frac_pll.c

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_gate.h

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_gate.c

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_mux.h

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_mux.c

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_sscg_pll.h

Loading...
View Options

sys/arm64/freescale/imx/clk/imx_clk_sscg_pll.c

Loading...
View Options

sys/arm64/freescale/imx/imx7gpc.c

Loading...
View Options

sys/arm64/freescale/imx/imx8mq_ccm.h

Loading...
View Options

sys/arm64/freescale/imx/imx8mq_ccm.c

Loading...
View Options

sys/arm64/freescale/imx/imx_ccm_clk.h

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/conf/options.arm64

Loading...
View Options

sys/dev/ffec/if_ffec.c

Loading...
View Options

sys/dev/uart/uart_dev_imx.c

Loading...
View Options

sys/modules/dtb/imx8/Makefile

Loading...