Supply RB_COLOR macro
ClosedPublic
Actions

Authored by dougm on Jun 9 2020, 11:14 PM.

Tags

None

Referenced Files

	F136955475: D25204.id.diff
	Thu, Nov 20, 8:06 PM

	F136955276: D25204.id72908.diff
	Thu, Nov 20, 8:05 PM

	F136954717: D25204.id72903.diff
	Thu, Nov 20, 8:02 PM

	F136954634: D25204.id72906.diff
	Thu, Nov 20, 8:01 PM

	F136954522: D25204.id72904.diff
	Thu, Nov 20, 8:01 PM

	F136952665: D25204.diff
	Thu, Nov 20, 7:52 PM

	Unknown Object (File)
	Tue, Nov 18, 5:47 AM

	Unknown Object (File)
	Mon, Nov 17, 12:47 AM

Subscribers

Details

Reviewers

markj

Commits

rS361997: Restore an RB_COLOR macro, for the benefit of a bit of DIAGNOSTIC code

Summary

Lint kernels define DIAGNOSTIC and depend on RB_COLOR in subr_stats.c. Provide an RB_COLOR macro for them.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm requested review of this revision.Jun 9 2020, 11:14 PM

dougm created this revision.

Include the root-of-tree case.

Same change as before, from the right directory this time.

I'm also happy to just change the subr_stats.c code. Having RB_TREE and ARB_TREE bound tightly like this makes another RB_TREE change I'm considering impossible.

I think this is fine as an interim solution if it fixes the build. I don't see any problem with modifying the stats code as you see fit, though. It was added to FreeBSD only quite recently.

This revision is now accepted and ready to land.Jun 9 2020, 11:53 PM

Closed by commit rS361997: Restore an RB_COLOR macro, for the benefit of a bit of DIAGNOSTIC code (authored by dougm). · Explain WhyJun 10 2020, 2:50 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS361997: Restore an RB_COLOR macro, for the benefit of a bit of DIAGNOSTIC code.

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2020, 2:50 AM