Details

Reviewers

jeffrey.e.pieper_intel.com
erj

Group Reviewers

Intel Networking

Commits

rS361992: ixl(4): Add FW recovery mode support and other things

Summary

Update of the iflib version of ixl driver based on OOT version ixl-1.11.29.
Major changes:

Extract iflib specific functions from ixl_pf_main.c to ixl_pf_iflib.c to simplify code sharing between legacy and iflib version of driver
Add support for most recent FW API version (1.10), which extends FW LLDP Agent control by user to X722 devices
Improve handling of a device global reset
Add support for the FW recovery mode
Use virtchnl function to validate virtual channel messages instead of own implementation
Fix MAC/VLAN filters accounting

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31600
Build 29189: arc lint + arc unit

Event Timeline

krzysztof.galazka_intel.com created this revision.Apr 24 2020, 9:03 PM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 24 2020, 9:03 PM

Harbormaster completed remote builds in B30714: Diff 70961.Apr 24 2020, 9:03 PM

Fix receiving broadcast frames after reset

Harbormaster completed remote builds in B30892: Diff 71356.May 4 2020, 1:14 PM

Don't process admin queue if its not configured

If reconfiguration of admin queue failed while handling reset e.g. after NVM update then don't try to process it to avoid panic.

Harbormaster completed remote builds in B30972: Diff 71523.May 7 2020, 10:26 PM

Remove redundant PF reset after EMP reset

ixl_handle_empr takes care of PF reset. Triggering it again while rebuilding configuration is not necessary and may cause problems.

Harbormaster completed remote builds in B31052: Diff 71697.May 12 2020, 7:32 PM

Fix sysctl ctx handling in IAVF

IAVF shares some of sysctl management functions with IXL, which started using dynamic sysctl context to manage VSI statistics. IAVF was not adapted to that and could crash because of using uninitialized context. Change the function adding statistics to accept ctx pointer and pass the dynamic context in IXL and default device context in IAVF.

Harbormaster completed remote builds in B31445: Diff 72575.Jun 2 2020, 5:50 PM

jeffrey.e.pieper_intel.com accepted this revision.Jun 4 2020, 2:03 PM

This revision is now accepted and ready to land.Jun 4 2020, 2:03 PM

Before I commit this, I'd like to have a better description of the changes that are going into this patch; I see there are changes around Recovery Mode support, but I'd like things like significant bugs or feature additions to be called out since this is pretty large.

As well, could you try to say what the equivalent OOT driver version is, too?

sys/dev/ixl/ixl_pf.h
136	This conditional should be removed?

This revision now requires changes to proceed.Jun 4 2020, 8:31 PM

Replace 'if 1' with 'ifdef IXL_DEBUG' in ixl_pf.h to match with if_ixl.c

Harbormaster completed remote builds in B31600: Diff 72892.Jun 9 2020, 10:02 PM

krzysztof.galazka_intel.com marked an inline comment as done.Jun 9 2020, 10:02 PM

This description looks better; thanks.

erj accepted this revision.Jun 9 2020, 10:38 PM

This revision is now accepted and ready to land.Jun 9 2020, 10:38 PM

I committed this in rS361992.

erj added a commit: rS361992: ixl(4): Add FW recovery mode support and other things.Jun 10 2020, 4:11 PM

ixl(4): Add FW recovery mode support
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 72892

sys/conf/files.amd64

sys/conf/files.powerpc

sys/dev/ixl/i40e_adminq.c

sys/dev/ixl/i40e_adminq_cmd.h

sys/dev/ixl/i40e_common.c

sys/dev/ixl/i40e_dcb.h

sys/dev/ixl/i40e_dcb.c

sys/dev/ixl/i40e_devids.h

sys/dev/ixl/i40e_lan_hmc.c

sys/dev/ixl/i40e_nvm.c

sys/dev/ixl/i40e_osdep.c

sys/dev/ixl/i40e_prototype.h

sys/dev/ixl/i40e_register.h

sys/dev/ixl/i40e_type.h

sys/dev/ixl/if_iavf.c

sys/dev/ixl/if_ixl.c

sys/dev/ixl/ixl.h

sys/dev/ixl/ixl_pf.h

sys/dev/ixl/ixl_pf_i2c.c

sys/dev/ixl/ixl_pf_iflib.c

sys/dev/ixl/ixl_pf_iov.c

sys/dev/ixl/ixl_pf_main.c

sys/dev/ixl/ixl_txrx.c

sys/modules/ixl/Makefile

ixl(4): Add FW recovery mode supportClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 72892

sys/conf/files.amd64

sys/conf/files.powerpc

sys/dev/ixl/i40e_adminq.c

sys/dev/ixl/i40e_adminq_cmd.h

sys/dev/ixl/i40e_common.c

sys/dev/ixl/i40e_dcb.h

sys/dev/ixl/i40e_dcb.c

sys/dev/ixl/i40e_devids.h

sys/dev/ixl/i40e_lan_hmc.c

sys/dev/ixl/i40e_nvm.c

sys/dev/ixl/i40e_osdep.c

sys/dev/ixl/i40e_prototype.h

sys/dev/ixl/i40e_register.h

sys/dev/ixl/i40e_type.h

sys/dev/ixl/if_iavf.c

sys/dev/ixl/if_ixl.c

sys/dev/ixl/ixl.h

sys/dev/ixl/ixl_pf.h

sys/dev/ixl/ixl_pf_i2c.c

sys/dev/ixl/ixl_pf_iflib.c

sys/dev/ixl/ixl_pf_iov.c

sys/dev/ixl/ixl_pf_main.c

sys/dev/ixl/ixl_txrx.c

sys/modules/ixl/Makefile

ixl(4): Add FW recovery mode support
ClosedPublic
Actions

Revision Contents
Changeset List