Page MenuHomeFreeBSD
Differential D24749

Deduplicate fsid comparisons
ClosedPublic
Actions

Authored by freqlabs on May 7 2020, 4:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 17, 9:27 PM
Unknown Object (File)
Mon, Feb 17, 9:19 PM
Unknown Object (File)
Tue, Feb 11, 9:28 PM
Unknown Object (File)
Tue, Feb 11, 9:28 PM
Unknown Object (File)
Tue, Feb 11, 9:27 PM
Unknown Object (File)
Wed, Jan 29, 6:30 PM
Unknown Object (File)
Jan 23 2025, 4:09 PM
Unknown Object (File)
Jan 19 2025, 10:58 PM
View All 85 Files
Subscribers
imp
mav
Contributor Reviews (src)

Details

Reviewers
rmacklem
trasz
mjg
Commits
rS361589: MFC r361313:
rS361313: Deduplicate fsid comparisons
Summary

Comparing fsid_t objects requires internal knowledge of the fsid structure and yet this is duplicated across a number of places in the code.

Simplify by creating a fsidcmp function.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

freqlabs created this revision.May 7 2020, 4:46 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMay 7 2020, 4:46 PM
freqlabs requested review of this revision.May 7 2020, 4:46 PM
freqlabs updated this revision to Diff 71521.May 7 2020, 10:01 PM
freqlabs edited the summary of this revision. (Show Details)
freqlabs added reviewers: rmacklem, trasz, mjg.
freqlabs added a subscriber: mav.
mjg added inline comments.May 7 2020, 11:07 PM
sys/sys/mount.h
59 ↗(On Diff #71521)

I think it would be cleaner to just to turn this into an actual function.

59 ↗(On Diff #71521)

.. it can land in vfs_subr.c

freqlabs added inline comments.May 8 2020, 2:50 PM
sys/sys/mount.h
59 ↗(On Diff #71521)

I'll have to get it into userland somewhere, too.

freqlabs marked an inline comment as not done.May 8 2020, 2:52 PM
mjg added inline comments.May 9 2020, 9:16 PM
sys/sys/mount.h
59 ↗(On Diff #71521)

Oh, my bad. In that case just turn in into a macro. We can survive without type checking for this one but it can still be added "by hand". Then it can just "memcmp and the comment can be removed.

freqlabs updated this revision to Diff 71620.May 10 2020, 6:35 PM

Make fsidcmp a macro

freqlabs marked an inline comment as done.May 10 2020, 6:36 PM
mjg accepted this revision.May 10 2020, 8:19 PM
This revision is now accepted and ready to land.May 10 2020, 8:19 PM
freqlabs marked 2 inline comments as done.May 14 2020, 11:59 AM
Closed by commit rS361313: Deduplicate fsid comparisons (authored by freqlabs). · Explain WhyMay 21 2020, 1:56 AM
This revision was automatically updated to reflect the committed changes.
freqlabs added a commit: rS361313: Deduplicate fsid comparisons.
freqlabs added a commit: rS361589: MFC r361313:.May 28 2020, 5:09 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libugidfw/
5 lines
sbin/
mksnap_ffs/
3 lines
umount/
3 lines
sys/
fs/
nfs/
3 lines
nfsserver/
22 lines
8 lines
15 lines
kern/
13 lines
security/
mac_bsdextended/
2 lines
5 lines
sys/
2 lines
usr.sbin/
autofs/
3 lines
mountd/
15 lines

Diff 72061

View Options

head/lib/libugidfw/ugidfw.c

Loading...
View Options

head/sbin/mksnap_ffs/mksnap_ffs.c

Loading...
View Options

head/sbin/umount/umount.c

Loading...
View Options

head/sys/fs/nfs/nfsdport.h

Loading...
View Options

head/sys/fs/nfsserver/nfs_nfsdport.c

Loading...
View Options

head/sys/fs/nfsserver/nfs_nfsdsocket.c

Loading...
View Options

head/sys/fs/nfsserver/nfs_nfsdstate.c

Loading...
View Options

head/sys/kern/vfs_subr.c

Loading...
View Options

head/sys/security/mac_bsdextended/mac_bsdextended.h

Loading...
View Options

head/sys/security/mac_bsdextended/mac_bsdextended.c

Loading...
View Options

head/sys/sys/mount.h

Loading...
View Options

head/usr.sbin/autofs/autounmountd.c

Loading...
View Options

head/usr.sbin/mountd/mountd.c

Loading...