Page MenuHomeFreeBSD
Differential D24564

ixl(4): Add FW recovery mode support
ClosedPublic
Actions

Authored by krzysztof.galazka_intel.com on Apr 24 2020, 9:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 7:32 AM
Unknown Object (File)
Sun, Nov 24, 1:19 AM
Unknown Object (File)
Thu, Nov 14, 7:00 AM
Unknown Object (File)
Thu, Nov 14, 6:34 AM
Unknown Object (File)
Sun, Nov 10, 4:54 AM
Unknown Object (File)
Sun, Nov 3, 9:29 PM
Unknown Object (File)
Sun, Nov 3, 9:29 PM
Unknown Object (File)
Sun, Nov 3, 9:29 PM
View All Files
Subscribers
ae
erj
imp

Details

Reviewers
jeffrey.e.pieper_intel.com
erj
Group Reviewers
Intel Networking
Commits
rS361992: ixl(4): Add FW recovery mode support and other things
Summary

Update of the iflib version of ixl driver based on OOT version ixl-1.11.29.
Major changes:

  • Extract iflib specific functions from ixl_pf_main.c to ixl_pf_iflib.c to simplify code sharing between legacy and iflib version of driver
  • Add support for most recent FW API version (1.10), which extends FW LLDP Agent control by user to X722 devices
  • Improve handling of a device global reset
  • Add support for the FW recovery mode
  • Use virtchnl function to validate virtual channel messages instead of own implementation
  • Fix MAC/VLAN filters accounting

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30972
Build 28680: arc lint + arc unit

Event Timeline

krzysztof.galazka_intel.com created this revision.Apr 24 2020, 9:03 PM
Herald added subscribers: ae, imp. · View Herald TranscriptApr 24 2020, 9:03 PM
Harbormaster completed remote builds in B30714: Diff 70961.Apr 24 2020, 9:03 PM
krzysztof.galazka_intel.com updated this revision to Diff 71356.May 4 2020, 1:14 PM
  • Fix receiving broadcast frames after reset
Harbormaster completed remote builds in B30892: Diff 71356.May 4 2020, 1:14 PM
krzysztof.galazka_intel.com updated this revision to Diff 71523.May 7 2020, 10:25 PM
  • Don't process admin queue if its not configured

If reconfiguration of admin queue failed while handling reset e.g. after NVM update then don't try to process it to avoid panic.

Harbormaster completed remote builds in B30972: Diff 71523.May 7 2020, 10:26 PM
krzysztof.galazka_intel.com updated this revision to Diff 71697.May 12 2020, 7:32 PM
  • Remove redundant PF reset after EMP reset

ixl_handle_empr takes care of PF reset. Triggering it again while rebuilding configuration is not necessary and may cause problems.

Harbormaster completed remote builds in B31052: Diff 71697.May 12 2020, 7:32 PM
krzysztof.galazka_intel.com updated this revision to Diff 72575.Jun 2 2020, 5:50 PM
  • Fix sysctl ctx handling in IAVF

IAVF shares some of sysctl management functions with IXL, which started using dynamic sysctl context to manage VSI statistics. IAVF was not adapted to that and could crash because of using uninitialized context. Change the function adding statistics to accept ctx pointer and pass the dynamic context in IXL and default device context in IAVF.

Harbormaster completed remote builds in B31445: Diff 72575.Jun 2 2020, 5:50 PM
jeffrey.e.pieper_intel.com accepted this revision.Jun 4 2020, 2:03 PM
This revision is now accepted and ready to land.Jun 4 2020, 2:03 PM
erj requested changes to this revision.Jun 4 2020, 8:31 PM
erj added a subscriber: erj.

Before I commit this, I'd like to have a better description of the changes that are going into this patch; I see there are changes around Recovery Mode support, but I'd like things like significant bugs or feature additions to be called out since this is pretty large.

As well, could you try to say what the equivalent OOT driver version is, too?

sys/dev/ixl/ixl_pf.h
136

This conditional should be removed?

This revision now requires changes to proceed.Jun 4 2020, 8:31 PM
krzysztof.galazka_intel.com updated this revision to Diff 72892.Jun 9 2020, 10:01 PM
krzysztof.galazka_intel.com edited the summary of this revision. (Show Details)
  • Replace 'if 1' with 'ifdef IXL_DEBUG' in ixl_pf.h to match with if_ixl.c
Harbormaster completed remote builds in B31600: Diff 72892.Jun 9 2020, 10:02 PM
krzysztof.galazka_intel.com marked an inline comment as done.Jun 9 2020, 10:02 PM
erj accepted this revision as: erj.Jun 9 2020, 10:37 PM

This description looks better; thanks.

erj accepted this revision.Jun 9 2020, 10:38 PM
This revision is now accepted and ready to land.Jun 9 2020, 10:38 PM
erj closed this revision.Jun 10 2020, 4:10 PM

I committed this in rS361992.

erj added a commit: rS361992: ixl(4): Add FW recovery mode support and other things.Jun 10 2020, 4:11 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
2 lines
dev/
ixl/
138 lines
231 lines
590 lines
18 lines
91 lines
2 lines
15 lines
115 lines
28 lines
83 lines
38 lines
38 lines
2 lines
255 lines
29 lines
93 lines
14 lines
1144 lines
253 lines
2196 lines
11 lines
modules/
ixl/
3 lines

Diff 71523

View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.powerpc

Loading...
View Options

sys/dev/ixl/i40e_adminq.c

Loading...
View Options

sys/dev/ixl/i40e_adminq_cmd.h

Loading...
View Options

sys/dev/ixl/i40e_common.c

Loading...
View Options

sys/dev/ixl/i40e_dcb.h

Loading...
View Options

sys/dev/ixl/i40e_dcb.c

Loading...
View Options

sys/dev/ixl/i40e_devids.h

Loading...
View Options

sys/dev/ixl/i40e_lan_hmc.c

Loading...
View Options

sys/dev/ixl/i40e_nvm.c

Loading...
View Options

sys/dev/ixl/i40e_osdep.c

Loading...
View Options

sys/dev/ixl/i40e_prototype.h

Loading...
View Options

sys/dev/ixl/i40e_register.h

Loading...
View Options

sys/dev/ixl/i40e_type.h

Loading...
View Options

sys/dev/ixl/if_iavf.c

Loading...
View Options

sys/dev/ixl/if_ixl.c

Loading...
View Options

sys/dev/ixl/ixl.h

Loading...
View Options

sys/dev/ixl/ixl_pf.h

Loading...
View Options

sys/dev/ixl/ixl_pf_i2c.c

Loading...
View Options

sys/dev/ixl/ixl_pf_iflib.c

Loading...
View Options

sys/dev/ixl/ixl_pf_iov.c

Loading...
View Options

sys/dev/ixl/ixl_pf_main.c

Loading...
View Options

sys/dev/ixl/ixl_txrx.c

Loading...
View Options

sys/modules/ixl/Makefile

Loading...