[PowerPC] Set fixed boot1.elf load address
ClosedPublic
Actions

Authored by bdragon on Apr 29 2020, 7:04 PM.

Details

Reviewers

jhibbits
nwhitehorn
alfredo

Commits

rS360537: [PowerPC] Set fixed boot1.elf load address

Summary

Due to the way claiming works, we need to ensure on AIM OFW machines that we don't have overlapping ranges on any step of the load.

Load boot1.elf at 0x38000 so it will not overlap with anything even if the entire PReP partition gets loaded by OFW.

Tested on an iBook G4, a PowerBook G4, a PowerMac G5, and qemu pseries. (which is currently broken without this patch due to lld chosing an absurdly high load address by default)

Test Plan

Install FreeBSD/powerpc on various AIM/OFW machines.
Check that booting into kernel off of hard drive works.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Apr 29 2020, 7:04 PM

Herald added subscribers: luporl, imp. · View Herald TranscriptApr 29 2020, 7:04 PM

bdragon requested review of this revision.Apr 29 2020, 7:04 PM

Looks good! Applied your patch and I reach the kernel. I'm using QEMU 4.2 on POWER8 machine.

This revision is now accepted and ready to land.Apr 29 2020, 9:40 PM

Closed by commit rS360537: [PowerPC] Set fixed boot1.elf load address (authored by bdragon). · Explain WhyMay 1 2020, 4:56 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS360537: [PowerPC] Set fixed boot1.elf load address.

Revision Contents
Changeset List

Path

Size

head/

stand/

powerpc/

boot1.chrp/

Makefile

15 lines

Diff 71246

View Options

head/stand/powerpc/boot1.chrp/Makefile

[PowerPC] Set fixed boot1.elf load addressClosedPublicActions