ixl: Add MAC+VLAN filter for LAA MAC assignment
ClosedPublic
Actions

Authored by erj on Jul 16 2015, 10:22 PM.

Details

Reviewers

gnn
rstone

Summary

Fix for a customer issue:

Add required MAC/VLAN filter when adding an LAA
Fix bug where code did not check for I40E_SUCCESS from a successful i40e_validate_mac_address() call in init_locked(), when setting an LAA.

Patch submitted by: Greg Rose <gregory.v.rose@intel.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

erj updated this revision to Diff 7031.Jul 16 2015, 10:22 PM

erj retitled this revision from to ixl: Add MAC+VLAN filter for LAA MAC assignment.

erj updated this object.

erj edited the test plan for this revision. (Show Details)

erj added a reviewer: gnn.

erj set the repository for this revision to rS FreeBSD src repository - subversion.

erj added a project: network.

Herald added a subscriber: imp. · View Herald TranscriptJul 16 2015, 10:22 PM

erj added a reviewer: rstone.Jul 16 2015, 10:23 PM

rstone added inline comments.Jul 16 2015, 11:57 PM

sys/dev/ixl/if_ixl.c
1145	the indendation looks like it went here

gnn accepted this revision.Jul 17 2015, 1:21 AM

gnn edited edge metadata.

gnn added inline comments.

sys/dev/ixl/if_ixl.c
1145	I'd also add an extra pair of () around the == clause there.

This revision is now accepted and ready to land.Jul 17 2015, 1:21 AM

Fix indentation and add parentheses around validate_mac_addr() check.

This revision now requires review to proceed.Jul 20 2015, 5:26 PM

Approved.

This revision is now accepted and ready to land.Jul 21 2015, 8:06 PM

In with r285768.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

if_ixl.c

5 lines

Diff 7105

View Options

ixl: Add MAC+VLAN filter for LAA MAC assignmentClosedPublicActions