Page MenuHomeFreeBSD
Differential D24196

Document the exit status and the message of nologin(8)
ClosedPublic
Actions

Authored by 0mp on Mar 26 2020, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 30, 3:39 PM
Unknown Object (File)
Sun, Jul 26, 4:52 PM
Unknown Object (File)
Wed, Jul 22, 10:07 PM
Unknown Object (File)
Tue, Jul 21, 10:26 AM
Unknown Object (File)
Tue, Jul 21, 4:45 AM
Unknown Object (File)
Fri, Jul 3, 12:48 PM
Unknown Object (File)
Jul 2 2026, 4:37 PM
Unknown Object (File)
Jun 30 2026, 7:08 AM
View All Files
Subscribers
debdrup
imp
yuripv

Details

Reviewers
bcr
Group Reviewers
manpages
Commits
rS363554: MFC 359967:
rS359967: Document the exit status and the stdout message of nologin(8)
Summary
Document the exit status and the message of nologin(8)

MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Mar 26 2020, 6:14 PM
Herald added a reviewer: manpages. · View Herald TranscriptMar 26 2020, 6:14 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B30118: Diff 69898.Mar 26 2020, 6:14 PM
0mp edited the summary of this revision. (Show Details)Mar 26 2020, 6:15 PM
0mp added a reviewer: bcr.Mar 26 2020, 7:39 PM
debdrup added a subscriber: debdrup.Mar 26 2020, 8:46 PM

According to mdoc(7), the .Li macro is deprecated - should Ql be used instead?

Other than that, it looks good to me, but I don't think I can approve in good conscience.

0mp updated this revision to Diff 70018.Mar 30 2020, 7:55 PM
  • Add EXAMPLES
  • Rewrite description
Harbormaster completed remote builds in B30192: Diff 70018.Mar 30 2020, 7:55 PM
0mp added a comment.Mar 30 2020, 7:56 PM
In D24196#532232, @debdrup wrote:

According to mdoc(7), the .Li macro is deprecated - should Ql be used instead?

Oh, that's new! Thank you

This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2020, 1:14 PM
Closed by commit rS359967: Document the exit status and the stdout message of nologin(8) (authored by 0mp). · Explain Why
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rS359967: Document the exit status and the stdout message of nologin(8).
0mp added a commit: rS363554: MFC 359967:.Jul 26 2020, 10:04 AM
yuripv added a subscriber: yuripv.Jul 26 2020, 10:12 AM
yuripv added inline comments.
head/usr.sbin/nologin/nologin.8
47

I'm late to the party as always, just noticed the MFC commit, but anyway.

This sentence sounds somewhat broken to me, you don't write to a function, rather log something using syslog(3)?

49

Erroneous 'a' after 'then'.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
nologin/
25 lines

Diff 70600

View Options

head/usr.sbin/nologin/nologin.8

Loading...