Page MenuHomeFreeBSD
Differential D24410

Don't directly access userspace memory.
ClosedPublic
Actions

Authored by brooks on Apr 13 2020, 11:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 1:54 PM
Unknown Object (File)
Thu, Nov 20, 1:53 PM
Unknown Object (File)
Thu, Nov 20, 1:47 PM
Unknown Object (File)
Thu, Nov 20, 1:45 PM
Unknown Object (File)
Wed, Nov 19, 3:14 AM
Unknown Object (File)
Tue, Oct 28, 9:27 PM
Unknown Object (File)
Oct 17 2025, 10:33 PM
Unknown Object (File)
Oct 17 2025, 10:33 PM
View All 82 Files
Subscribers
None

Details

Reviewers
imp
jhb
adrian
jrtc27
Commits
rS360695: MFC r359974:
rS360693: MFC r359974:
rS359974: Don't directly access userspace memory.
Summary

Rather then using the racy useracc() followed by direct access to userspace
memory, perform a copyin() and use the result if it succeeds.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30480
Build 28234: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 13 2020, 11:56 PM
Harbormaster completed remote builds in B30480: Diff 70530.Apr 13 2020, 11:56 PM
jhb accepted this revision.Apr 15 2020, 3:41 PM
This revision is now accepted and ready to land.Apr 15 2020, 3:41 PM
imp accepted this revision.Apr 15 2020, 4:31 PM

Yikes!

Closed by commit rS359974: Don't directly access userspace memory. (authored by brooks). · Explain WhyApr 15 2020, 4:33 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rS359974: Don't directly access userspace memory..
brooks added a comment.Apr 15 2020, 4:36 PM
In D24410#537510, @imp wrote:

Yikes!

Yeah, I'm not convinced this should even exist, but making it less lame seemed like a good idea even if we remove it. Sorry I raced your review with my commit.

There's one more useracc in this file that I don't understand yet.

brooks added a commit: rS360693: MFC r359974:.May 6 2020, 5:12 PM
brooks added a commit: rS360695: MFC r359974:.May 6 2020, 5:42 PM

Revision Contents
Changeset List

PathSize
sys/
mips/
mips/
21 lines

Diff 70530

View Options

sys/mips/mips/trap.c

Loading...