Don't directly access userspace memory.
ClosedPublic
Actions

Authored by brooks on Apr 13 2020, 11:56 PM.

Tags

None

Referenced Files

	F153520742: D24410.id70606.diff
	Tue, Apr 21, 2:47 PM

	F153450765: D24410.diff
	Tue, Apr 21, 6:10 AM

	Unknown Object (File)
	Mon, Apr 20, 11:29 AM

	Unknown Object (File)
	Wed, Apr 15, 8:01 AM

	Unknown Object (File)
	Mon, Apr 13, 9:48 AM

	Unknown Object (File)
	Sun, Apr 12, 3:49 PM

	Unknown Object (File)
	Thu, Apr 9, 6:44 PM

	Unknown Object (File)
	Thu, Apr 9, 3:52 AM

View All Files

Subscribers

None

Details

Reviewers

imp
jhb
adrian
jrtc27

Commits

rS360695: MFC r359974:
rS360693: MFC r359974:
rS359974: Don't directly access userspace memory.

Summary

Rather then using the racy useracc() followed by direct access to userspace
memory, perform a copyin() and use the result if it succeeds.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Apr 13 2020, 11:56 PM

Harbormaster completed remote builds in B30480: Diff 70530.Apr 13 2020, 11:56 PM

jhb accepted this revision.Apr 15 2020, 3:41 PM

This revision is now accepted and ready to land.Apr 15 2020, 3:41 PM

Yikes!

Closed by commit rS359974: Don't directly access userspace memory. (authored by brooks). · Explain WhyApr 15 2020, 4:33 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS359974: Don't directly access userspace memory..

In D24410#537510, @imp wrote:

Yikes!

Yeah, I'm not convinced this should even exist, but making it less lame seemed like a good idea even if we remove it. Sorry I raced your review with my commit.

There's one more useracc in this file that I don't understand yet.

brooks added a commit: rS360693: MFC r359974:.May 6 2020, 5:12 PM

brooks added a commit: rS360695: MFC r359974:.May 6 2020, 5:42 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

trap.c

21 lines

Diff 70606

View Options

Don't directly access userspace memory.ClosedPublicActions