map capability string for VM_CAP_BPT_EXIT
ClosedPublic
Actions

Authored by rew on Apr 4 2020, 2:41 AM.

Details

Reviewers

araujo
jhb
rgrimes

Group Reviewers

bhyve

Commits

rS360166: Add description string for VM_CAP_BPT_EXIT.

Summary

This patch adds a descriptive string for mapping to the VM_CAP_BPT_EXIT.
I noticed this when using bhyvectl to identify the vmm capabilities.

Test Plan

without patch:

$ bhyvectl --vm vm --getcap
Capability "hlt_exit" is set on vcpu 0
Capability "mtrap_exit" is not available
Capability "pause_exit" is set on vcpu 0
Capability "unrestricted_guest" is set on vcpu 0
Capability "enable_invpcid" is not available
Capability "(null)" is not available

with patch:

$ bhyvectl --vm vm --getcap
Capability "hlt_exit" is set on vcpu 0
Capability "mtrap_exit" is not available
Capability "pause_exit" is set on vcpu 0
Capability "unrestricted_guest" is set on vcpu 0
Capability "enable_invpcid" is not available
Capability "bpt_exit" is not available

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30339
Build 28107: arc lint + arc unit

Event Timeline

rew created this revision.Apr 4 2020, 2:41 AM

Herald added a reviewer: bhyve. · View Herald TranscriptApr 4 2020, 2:41 AM

Herald added a subscriber: rgrimes. · View Herald Transcript

Harbormaster completed remote builds in B30279: Diff 70183.Apr 4 2020, 2:41 AM

Looks like this was missed in commit rS355724 for review D20309.

This revision is now accepted and ready to land.Apr 4 2020, 8:47 AM

BTW, I would suggest replacing this structure with one indexed by the enum values and using nitems() and C99 initializers as a followup change, e.g.:

static const char *capstrmap[] = {
   [VM_CAP_HALT_EXIT] = "hlt_exit",
   ...
};

const char *
vm_capability_type2name(int type)
{
    if (type < nitems(capstrmap))
        return (capstrmap[type]);
    else
        return (NULL);
}

vm_capability_name2type would still have to do a loop, but would use`'i < nitems(capstrmap)` as the terminating condition for the loop.

Updating D24289: map capability string for VM_CAP_BPT_EXIT

John, per your suggestion.

capstrmap is now indexed by enum vm_cap_type.

This revision now requires review to proceed.Apr 7 2020, 3:45 PM

Harbormaster completed remote builds in B30339: Diff 70299.Apr 7 2020, 3:45 PM

jhb accepted this revision.Apr 7 2020, 10:58 PM

This revision is now accepted and ready to land.Apr 7 2020, 10:58 PM

Closed by commit rS360166: Add description string for VM_CAP_BPT_EXIT. (authored by jhb). · Explain WhyApr 21 2020, 5:31 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS360166: Add description string for VM_CAP_BPT_EXIT..

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2020, 5:31 PM