Paths

Table of Contentst

Differential D24206

Use the real value of MK_TESTS_SUPPORT in _libraries.
ClosedPublic
Actions

Authored by brooks on Mar 27 2020, 8:31 PM.

Tags

None

Referenced Files

	F171463212: D24206.id.diff
	Fri, Sep 11, 6:14 AM

	F171378337: D24206.id69941.diff
	Thu, Sep 10, 7:21 PM

	F171329763: D24206.id69942.diff
	Thu, Sep 10, 11:23 AM

	Unknown Object (File)
	Thu, Sep 10, 7:39 AM

	Unknown Object (File)
	Thu, Sep 10, 2:18 AM

	Unknown Object (File)
	Wed, Sep 9, 8:36 AM

	Unknown Object (File)
	Sat, Sep 5, 11:07 PM

	Unknown Object (File)
	Tue, Sep 1, 8:21 PM

Subscribers

None

Details

Reviewers

imp
emaste
bdrewery

Commits

rS359382: Use the real value of MK_TESTS_SUPPORT in _libraries.

Summary

This fixes WITHOUT_TESTS + WITH_TESTS_SUPPORT builds.

r273449 added WITH_TESTS_SUPPORT and set MK_TESTS_SUPPORT to MK_TESTS in
this stage due to a claimed race betwen lib/atf and libexec/atf. It's
not apparent how this could ever happen and not fully populating
WORLDTMP in _libraries seems wrong.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30139
Build 27945: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 27 2020, 8:31 PM

Harbormaster completed remote builds in B30139: Diff 69933.Mar 27 2020, 8:31 PM

Seems reasonable to me

This revision is now accepted and ready to land.Mar 27 2020, 8:49 PM

This definitely doesn't work. https://cirrus-ci.com/task/5639234392424448 (Breaks normal builds).

I believe what's happening is that MK_TESTS=no is causing MK_TESTS_SUPPORT to be implied in the sub make. I'm now testing a change where we pass the currently value of MK_TESTS_SUPPORT on through.

Take two: carry MK_TESTS_SUPPORT through regardless of MK_TESTS.

This revision now requires review to proceed.Mar 27 2020, 11:11 PM

Harbormaster completed remote builds in B30143: Diff 69941.Mar 27 2020, 11:11 PM

Successful CI run with updated patch: https://cirrus-ci.com/task/5744739794288640

Also successfully built with make -j16 -DWITHOUT_TESTS -DWITH_TESTS_SUPPORT buildworld

emaste accepted this revision.Mar 27 2020, 11:21 PM

This revision is now accepted and ready to land.Mar 27 2020, 11:21 PM

Closed by commit rS359382: Use the real value of MK_TESTS_SUPPORT in _libraries. (authored by brooks). · Explain WhyMar 27 2020, 11:28 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS359382: Use the real value of MK_TESTS_SUPPORT in _libraries..

Looks good to me, though it looks like I'm a little late to say so...

Revision Contents
Changeset List

Path

Size

2 lines

Diff 69933

Makefile.inc1

Loading...