Page MenuHomeFreeBSD
Differential D24206

Use the real value of MK_TESTS_SUPPORT in _libraries.
ClosedPublic
Actions

Authored by brooks on Mar 27 2020, 8:31 PM.
Tags
None
Referenced Files
F103492202: D24206.diff
Mon, Nov 25, 5:18 PM
Unknown Object (File)
Wed, Nov 13, 11:32 PM
Unknown Object (File)
Wed, Nov 13, 7:42 AM
Unknown Object (File)
Fri, Nov 1, 5:56 AM
Unknown Object (File)
Tue, Oct 29, 12:35 PM
Unknown Object (File)
Sep 30 2024, 4:52 PM
Unknown Object (File)
Sep 26 2024, 5:57 AM
Unknown Object (File)
Sep 21 2024, 2:03 PM
View All 41 Files
Subscribers
None

Details

Reviewers
imp
emaste
bdrewery
Commits
rS359382: Use the real value of MK_TESTS_SUPPORT in _libraries.
Summary

This fixes WITHOUT_TESTS + WITH_TESTS_SUPPORT builds.

r273449 added WITH_TESTS_SUPPORT and set MK_TESTS_SUPPORT to MK_TESTS in
this stage due to a claimed race betwen lib/atf and libexec/atf. It's
not apparent how this could ever happen and not fully populating
WORLDTMP in _libraries seems wrong.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30143
Build 27949: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 27 2020, 8:31 PM
Harbormaster completed remote builds in B30139: Diff 69933.Mar 27 2020, 8:31 PM
emaste accepted this revision.Mar 27 2020, 8:49 PM

Seems reasonable to me

This revision is now accepted and ready to land.Mar 27 2020, 8:49 PM
brooks added a comment.Mar 27 2020, 9:45 PM

This definitely doesn't work. https://cirrus-ci.com/task/5639234392424448 (Breaks normal builds).

brooks added a comment.Mar 27 2020, 9:49 PM

I believe what's happening is that MK_TESTS=no is causing MK_TESTS_SUPPORT to be implied in the sub make. I'm now testing a change where we pass the currently value of MK_TESTS_SUPPORT on through.

brooks updated this revision to Diff 69941.Mar 27 2020, 11:11 PM
  • Take two: carry MK_TESTS_SUPPORT through regardless of MK_TESTS.
This revision now requires review to proceed.Mar 27 2020, 11:11 PM
Harbormaster completed remote builds in B30143: Diff 69941.Mar 27 2020, 11:11 PM
brooks added a comment.Mar 27 2020, 11:11 PM

Successful CI run with updated patch: https://cirrus-ci.com/task/5744739794288640

brooks added a comment.Mar 27 2020, 11:16 PM

Also successfully built with make -j16 -DWITHOUT_TESTS -DWITH_TESTS_SUPPORT buildworld

emaste accepted this revision.Mar 27 2020, 11:21 PM
This revision is now accepted and ready to land.Mar 27 2020, 11:21 PM
Closed by commit rS359382: Use the real value of MK_TESTS_SUPPORT in _libraries. (authored by brooks). · Explain WhyMar 27 2020, 11:28 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rS359382: Use the real value of MK_TESTS_SUPPORT in _libraries..
imp added a comment.Mar 27 2020, 11:28 PM

Looks good to me, though it looks like I'm a little late to say so...

Revision Contents
Changeset List

PathSize
3 lines

Diff 69941

View Options

Makefile.inc1

Loading...