Details

Reviewers

alfredo
luporl
bdragon
jhibbits

Commits

rS359992: powerpc: autosize bpvo based on physical memory

Summary

Currently moea64_bpvo_pool_size has a hard coded value of 327680 which is insufficient for initial memory mapping at boot time on systems with, for example, 64G and no huge pages enabled. This patch sets moea64_bpvo_pool_size value based on physical memory plus an expansion factor.
The value estimation for moea64_bpvo_pool_size uses the physical memory and page size as input:

pages = physmem / PAGE_SIZE;
size = pages * sizeof(vm_page);
moea64_bpvo_pool_size = size / PAGE_SIZE * BPVO_POOL_EXPANSION_FACTOR;

Test Plan

For tests, use tool "stress" to allocate memory and see if no panic "bpvo pool exhausted" is raised.
Patch https://reviews.freebsd.org/rS358670 is necessary when stress testing.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30032
Build 27843: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Mar 17 2020, 5:53 PM

Herald added subscribers: bdragon, jhibbits. · View Herald TranscriptMar 17 2020, 5:53 PM

Harbormaster completed remote builds in B29983: Diff 69604.Mar 17 2020, 5:53 PM

afscoelho_gmail.com added reviewers: bdragon, jhibbits.Mar 17 2020, 7:08 PM

afscoelho_gmail.com edited the summary of this revision. (Show Details)Mar 18 2020, 4:58 PM

afscoelho_gmail.com edited the test plan for this revision. (Show Details)

Adjust moea64_bpvo_pool_size value only if hw_direct_map is false, otherwise set it to previous hard-coded value.

Harbormaster completed remote builds in B30000: Diff 69659.Mar 18 2020, 8:21 PM

jhibbits added inline comments.Mar 18 2020, 8:48 PM

sys/powerpc/aim/mmu_oea64.c
922	This needs to be a '== 0', since moea64_bpvo_pool_size is an integer used as an integer, not a boolean.
927	I'd make the 327680 a #define, commented that it's a sane historical default.

luporl added inline comments.Mar 19 2020, 11:35 AM

sys/powerpc/aim/mmu_oea64.c
924	It seems you are indenting with 2 spaces, but tabs should be used instead, except when you wrap long statements (as in the line below), then you should add 4 spaces. Check style(9).

Style (indentation, comparison) fixes.

Harbormaster completed remote builds in B30005: Diff 69680.Mar 19 2020, 12:42 PM

afscoelho_gmail.com marked 3 inline comments as done.Mar 19 2020, 12:43 PM

alfredo added inline comments.Mar 20 2020, 2:41 PM

sys/powerpc/aim/mmu_oea64.c
928	I think would be good print a message containing pool size and memory used by this pool when kernel boots is in verbose mode (boot -v). Something like: if (bootverbose) printf(".....\n");