modules.txt is missing
ClosedPublic
Actions

Authored by dmgk on Mar 19 2020, 1:48 PM.

Details

Reviewers

jlaffaye
tobik
mikael
yuri
swills

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP530489: MFH: r530388
rP530488: MFH: r530387
rP530388: Mk/Uses/go.mk: Set GO_NO_VENDOR_CHECKS=1
rP530387: lang/go: relax module consistency checks if vendor/modules.txt is missing

Summary

Starting from go1.14, go verifes that vendor/modules.txt matches the requirements
and replacements listed in the main module go.mod file, and it is a hard failure if
vendor/modules.txt is missing.

Relax module consistency checks and switch back to pre go1.14 behaviour if
vendor/modules.txt is missing regardless of go version requirement in go.mod.

Bugzilla PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244783
Upstream PR: https://github.com/golang/go/issues/37948

Test Plan

poudriere testport: OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 30010
Build 27823: arc lint + arc unit

Event Timeline

dmgk created this revision.Mar 19 2020, 1:48 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 19 2020, 1:48 PM

Harbormaster completed remote builds in B30006: Diff 69682.Mar 19 2020, 1:48 PM

It doesn't look like https://github.com/golang/go/issues/37948 is going to be accepted by the upstream, any objections to keeping this as a local lang/go patch?

dmgk added reviewers: tobik, mikael, yuri.Mar 19 2020, 5:53 PM

yuri accepted this revision.Mar 19 2020, 5:58 PM

This revision is now accepted and ready to land.Mar 19 2020, 5:58 PM

mikael accepted this revision.Mar 19 2020, 6:33 PM

Enable relaxed checks only when GO_NO_VENDOR_CHECKS=1 is set in the environment
(by go.mk) - this should limit custom behaviour to port builds.

This revision now requires review to proceed.Mar 19 2020, 8:35 PM

Owners added a reviewer: O5: Ports Framework.Mar 19 2020, 8:35 PM

Herald added a reviewer: portmgr. · View Herald TranscriptMar 19 2020, 8:35 PM

Harbormaster completed remote builds in B30010: Diff 69691.Mar 19 2020, 8:35 PM

dmgk added a reviewer: swills.Mar 19 2020, 8:36 PM

yuri accepted this revision.Mar 19 2020, 9:26 PM

mikael accepted this revision.Mar 20 2020, 12:31 PM