loader: remove libsa/crc32.c and use version from zlib
ClosedPublic
Actions

Authored by tsoome on Mar 14 2020, 3:48 PM.

Details

Reviewers

Commits

rS359153: loader: remove libsa/crc32.c and use version from zlib

Summary

we have crc32(const void *, size_t) in libsa. Unfortunately zlib has crc32(long, const unigned char *, unsigned) and we have conflict.

Since we do build libsa with zlib, we can use zlib version instead.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29939
Build 27756: arc lint + arc unit

Event Timeline

tsoome created this revision.Mar 14 2020, 3:48 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 14 2020, 3:48 PM

Harbormaster completed remote builds in B29936: Diff 69505.Mar 14 2020, 3:48 PM

missed stand/uboot/lib/glue.c

Harbormaster completed remote builds in B29937: Diff 69506.Mar 14 2020, 3:53 PM

I’d suggest using the zlib one unless it takes excessive space (bigger precomputed tables, for ex.).

In D24068#529184, @cem wrote:

I’d suggest using the zlib one unless it takes excessive space (bigger precomputed tables, for ex.).

I did that in illumos:) I was not sure about the preferred way with freebsd; it is larger, but it is present anyhow because we do link zlib and it is referred.

In D24068#529188, @tsoome wrote:

I did that in illumos:) I was not sure about the preferred way with freebsd; it is larger, but it is present anyhow because we do link zlib and it is referred.

Ah, if we already link zlib I see no reason to include a second copy.

drop crc32 from libsa and use version provided by zlib.

Herald added a subscriber: bcran. · View Herald TranscriptMar 14 2020, 7:36 PM

Harbormaster completed remote builds in B29939: Diff 69512.Mar 14 2020, 7:36 PM

tsoome retitled this revision from loader: rename crc32 to crc32_libsa to loader: remove libsa/crc32.c and use version from zlib.Mar 14 2020, 8:42 PM

tsoome edited the summary of this revision. (Show Details)