Page MenuHomeFreeBSD
Differential D24030

Make grab_valid more consistent with other grab functions by requiring ZERO.
AcceptedPublic
Actions

Authored by jeff on Mar 11 2020, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 29, 10:50 PM
Unknown Object (File)
Dec 11 2025, 4:35 AM
Unknown Object (File)
Nov 26 2025, 12:50 PM
Unknown Object (File)
Nov 26 2025, 12:50 PM
Unknown Object (File)
Nov 26 2025, 12:50 PM
Unknown Object (File)
Nov 24 2025, 9:25 PM
Unknown Object (File)
Nov 16 2025, 12:55 AM
Unknown Object (File)
Oct 31 2025, 7:34 PM
View All 67 Files
Subscribers
emaste
imp

Details

Reviewers
alc
dougm
kib
markj
Summary

After this change vm_page_grab_valid() requires callers to specify ZERO if they want to fill in sparse files/objects. I audited all consumers and a couple wanted it and a couple did not. This makes valid much more consistent with the others although there are still quirks around NOWAIT/WAITFAIL that could be eliminated if necessary.

Test Plan

stress2

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29884
Build 27704: arc lint + arc unit

Event Timeline

jeff created this revision.Mar 11 2020, 8:27 PM
Herald added a subscriber: emaste. · View Herald TranscriptMar 11 2020, 8:27 PM
Harbormaster completed remote builds in B29884: Diff 69401.Mar 11 2020, 8:27 PM
jeff edited the summary of this revision. (Show Details)Mar 11 2020, 8:37 PM
jeff edited the test plan for this revision. (Show Details)
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMar 11 2020, 8:37 PM
kib accepted this revision.Mar 12 2020, 10:55 PM

I think that the behavior of VM_ALLOC_ZERO/has_page should be documented in the comment.

This revision is now accepted and ready to land.Mar 12 2020, 10:55 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
6 lines
kern/
4 lines
vm/
2 lines
3 lines
100 lines

Diff 69401

View Options

sys/compat/linuxkpi/common/src/linux_shmemfs.c

Loading...
View Options

sys/kern/uipc_shm.c

Loading...
View Options

sys/vm/vm_glue.c

Loading...
View Options

sys/vm/vm_object.c

Loading...
View Options

sys/vm/vm_page.c

Loading...