Differential D23857

Merge commit 7214f7a79 from llvm git (by Sam Elliott):
ClosedPublic
Actions

Authored by brooks on Feb 27 2020, 6:39 PM.

Tags

None

Referenced Files

	F106192479: D23857.diff
	Thu, Dec 26, 10:18 PM

	Unknown Object (File)
	Fri, Nov 29, 6:25 PM

	Unknown Object (File)
	Nov 23 2024, 10:47 AM

	Unknown Object (File)
	Nov 21 2024, 10:16 AM

	Unknown Object (File)
	Nov 18 2024, 8:02 AM

	Unknown Object (File)
	Nov 14 2024, 2:20 AM

	Unknown Object (File)
	Nov 12 2024, 9:44 AM

	Unknown Object (File)
	Nov 11 2024, 4:50 AM

View All 55 Files

Subscribers

Details

Reviewers

dim
jhb
jrtc27

Commits

rS358408: Merge commit 7214f7a79 from llvm git (by Sam Elliott):

Summary

[RISCV] Lower llvm.trap and llvm.debugtrap

Summary:
Until this commit, these have lowered to a call to abort().

`llvm.trap()` now lowers to `unimp`, which should trap on all systems.

`llvm.debugtrap()` now lowers to `ebreak`, which is exactly what this
instruction is for.

Reviewers: asb, luismarques

Reviewed By: asb

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69390

This fixes miscompilation resulting in linking failures with
INVARIANTS disabled.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Feb 27 2020, 6:39 PM

Harbormaster completed remote builds in B29648: Diff 68898.Feb 27 2020, 6:39 PM

This change is required to add a working GENERIC-NODEBUG kernel.

LGTM

This revision is now accepted and ready to land.Feb 27 2020, 7:11 PM

Closed by commit rS358408: Merge commit 7214f7a79 from llvm git (by Sam Elliott): (authored by brooks). · Explain WhyFeb 27 2020, 8:08 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS358408: Merge commit 7214f7a79 from llvm git (by Sam Elliott):.

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2020, 8:08 PM

dim mentioned this in rS360545: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.May 1 2020, 8:24 PM

dim mentioned this in rS360784: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.May 7 2020, 4:40 PM

dim mentioned this in rS360822: MF11 r360784:.May 8 2020, 6:55 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

llvm-project/

llvm/

lib/

Target/

RISCV/

RISCVISelLowering.cpp

3 lines

RISCVInstrInfo.td

10 lines

Diff 68909

head/contrib/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Loading...

head/contrib/llvm-project/llvm/lib/Target/RISCV/RISCVInstrInfo.td

Loading...