Differential D23857

Merge commit 7214f7a79 from llvm git (by Sam Elliott):
ClosedPublic
Actions

Authored by brooks on Feb 27 2020, 6:39 PM.

Tags

None

Referenced Files

	F164805234: D23857.id68909.diff
	Tue, Aug 4, 3:26 AM

	Unknown Object (File)
	Tue, Jul 21, 12:31 PM

	Unknown Object (File)
	Tue, Jul 21, 12:25 PM

	Unknown Object (File)
	Tue, Jul 21, 3:30 AM

	Unknown Object (File)
	Tue, Jul 21, 3:26 AM

	Unknown Object (File)
	Sat, Jul 18, 8:16 PM

	Unknown Object (File)
	Sat, Jul 18, 8:14 PM

	Unknown Object (File)
	Thu, Jul 9, 2:49 PM

Subscribers

Details

Reviewers

dim
jhb
jrtc27

Commits

rS358408: Merge commit 7214f7a79 from llvm git (by Sam Elliott):

Summary

[RISCV] Lower llvm.trap and llvm.debugtrap

Summary:
Until this commit, these have lowered to a call to abort().

`llvm.trap()` now lowers to `unimp`, which should trap on all systems.

`llvm.debugtrap()` now lowers to `ebreak`, which is exactly what this
instruction is for.

Reviewers: asb, luismarques

Reviewed By: asb

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69390

This fixes miscompilation resulting in linking failures with
INVARIANTS disabled.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29648
Build 27506: arc lint + arc unit

Event Timeline

brooks created this revision.Feb 27 2020, 6:39 PM

Harbormaster completed remote builds in B29648: Diff 68898.Feb 27 2020, 6:39 PM

This change is required to add a working GENERIC-NODEBUG kernel.

LGTM

This revision is now accepted and ready to land.Feb 27 2020, 7:11 PM

Closed by commit rS358408: Merge commit 7214f7a79 from llvm git (by Sam Elliott): (authored by brooks). · Explain WhyFeb 27 2020, 8:08 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS358408: Merge commit 7214f7a79 from llvm git (by Sam Elliott):.

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2020, 8:08 PM

dim mentioned this in rS360545: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.May 1 2020, 8:24 PM

dim mentioned this in rS360784: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.May 7 2020, 4:40 PM

dim mentioned this in rS360822: MF11 r360784:.May 8 2020, 6:55 PM

Revision Contents
Changeset List

Path

Size

contrib/

llvm-project/

llvm/

lib/

Target/

RISCV/

RISCVISelLowering.cpp

3 lines

RISCVInstrInfo.td

10 lines

Diff 68898

contrib/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Loading...

contrib/llvm-project/llvm/lib/Target/RISCV/RISCVInstrInfo.td

Loading...