Add pthread_peekjoin_np(3).
ClosedPublic
Actions

Authored by kib on Feb 13 2020, 11:46 PM.

Details

Reviewers

jilles
emaste
markj

Commits

rS357985: Add pthread_peekjoin_np(3).

Summary

See man page for details. In short, the function allows to peek at the thread exit status and even see return value, without joining the target.

I wrote some tests for cancellation and needed a way to non-destructively see the exit state of the thread.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 29368

Event Timeline

kib created this revision.Feb 13 2020, 11:46 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2020, 11:46 PM

Harbormaster completed remote builds in B29367: Diff 68291.Feb 13 2020, 11:46 PM

Add context.

Harbormaster completed remote builds in B29368: Diff 68292.Feb 13 2020, 11:47 PM

I see that Linux has a non-blocking join, pthread_tryjoin_np(). Is that not sufficient for your purposes?

share/man/man3/pthread_join.3
40	Maybe "inspect thread termination state"?
98	"If the thread has not exited, the ..."
155	"did not yet exit" or "has not yet exited". I think the second one is more consistent with the rest of the man page.

In D23676#520034, @markj wrote:

I see that Linux has a non-blocking join, pthread_tryjoin_np(). Is that not sufficient for your purposes?

The tryjoin() method joins, while peekjoin() keeps the thread unjoined, which allows to peek or join again. The use for me was to see whether the thread exited, without disrupting an existing code that joined.

Our timedjoin() can be used as tryjoin() by providing the time in past. I can implement tryjoin() as well, if it is considered worth having explicit interface, to be source-compatible with Linux.

Man page edits.
Add symlink for man.

Harbormaster completed remote builds in B29385: Diff 68334.Feb 14 2020, 6:55 PM

In D23676#520058, @kib wrote:

In D23676#520034, @markj wrote:

I see that Linux has a non-blocking join, pthread_tryjoin_np(). Is that not sufficient for your purposes?

The tryjoin() method joins, while peekjoin() keeps the thread unjoined, which allows to peek or join again. The use for me was to see whether the thread exited, without disrupting an existing code that joined.

Our timedjoin() can be used as tryjoin() by providing the time in past. I can implement tryjoin() as well, if it is considered worth having explicit interface, to be source-compatible with Linux.

Ok. I don't really think it's necessary to implement the Linux extension without some candidate consumer. I was more just wondering how exactly your tests rely on the non-destructive behaviour of peekjoin.

This revision is now accepted and ready to land.Feb 14 2020, 7:29 PM

It was a test for r357894. The victim thread exiting, then I need to wait for it to exit but not join, to issue cancellation request.

Closed by commit rS357985: Add pthread_peekjoin_np(3). (authored by kib). · Explain WhyFeb 15 2020, 11:25 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS357985: Add pthread_peekjoin_np(3)..