Fixed bug where elfcopy --add-section needs to be called twice for section to be created
ClosedPublic
Actions

Authored by tig_freebsdfoundation.org on Feb 7 2020, 3:56 PM.

Details

Reviewers

emaste
markj
kaiw
jkoshy_users.sourceforge.net

Commits

rS359166: objcopy: add new sections also when there is no .shstrtab

Summary

The create_scn() (create section) function wants to place the new section before .shstrtab section but this section is added to the elf later in the main code. Thus it fails the first time and succeed the second time. I added a check so that if .shstrtab is not present the code still calls the insert_section function.
Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241437

Test Plan

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tig_freebsdfoundation.org created this revision.Feb 7 2020, 3:56 PM

tig_freebsdfoundation.org updated this revision to Diff 67939.Feb 7 2020, 3:58 PM

emaste added reviewers: markj, kaiw, jkoshy_users.sourceforge.net.Feb 7 2020, 9:08 PM

Thank you for the investigation and patch. I commented on a few minor items, I will update them before committing to svn (i.e., no need to reupload).

contrib/elftoolchain/elfcopy/sections.c
343	I'd probably call the new variable `sections_added`, and we can use C99 `bool`.
443–444	style(9) wants the `/` on its own line, i.e. / * Like this */