smr: add some missed fences.
AbandonedPublic
Actions

Authored by kib on Jan 31 2020, 6:16 PM.

Details

Reviewers

jeff
rlibby
andrew
markj

Commits

rS357352: smrstress: Add 'publishing' fences to operations on smrs_current.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 29074

Event Timeline

kib created this revision.Jan 31 2020, 6:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 31 2020, 6:16 PM

Harbormaster completed remote builds in B29072: Diff 67568.Jan 31 2020, 6:16 PM

Move release fence before fcmpset, otherwise it is useless.

Noted by jeff.

Harbormaster completed remote builds in B29074: Diff 67574.Jan 31 2020, 7:18 PM

jeff added inline comments.Jan 31 2020, 7:26 PM

sys/kern/subr_smr.c
327	what load is this applying to?
336	what is this synchronizing with and why not atomic_fcmpset_rel_int?

This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2020, 8:31 PM

Closed by commit rS357352: smrstress: Add 'publishing' fences to operations on smrs_current. (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS357352: smrstress: Add 'publishing' fences to operations on smrs_current..

Remove committed part.

Harbormaster completed remote builds in B29077: Diff 67580.Jan 31 2020, 8:33 PM

kib abandoned this revision.Feb 1 2020, 9:30 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_smr.c

5 lines

tools/

uma/

smrstress/

smrstress.c

3 lines

Diff 67574

View Options

sys/kern/subr_smr.c