Move the fault getpages code into its own function.
ClosedPublic
Actions

Authored by jeff on Jan 22 2020, 3:03 AM.

Details

Reviewers

alc
dougm
kib
markj

Commits

rS357025: (fault 6/9) Move getpages and associated logic into a dedicated function.

Summary

I left the readahead in the main loop because we don't need to repeat the dropbehind. However, storing the cached entry variables before unlocking the map was only done once before. I don't think this was important to the algorithm nor is it especially expensive.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28855
Build 26861: arc lint + arc unit

Event Timeline

jeff created this revision.Jan 22 2020, 3:03 AM

Harbormaster completed remote builds in B28836: Diff 67131.Jan 22 2020, 3:03 AM

Fix a merge issue.

Harbormaster completed remote builds in B28837: Diff 67132.Jan 22 2020, 3:08 AM

jeff edited the summary of this revision. (Show Details)Jan 22 2020, 3:10 AM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2020, 3:10 AM

kib added inline comments.Jan 22 2020, 1:31 PM

sys/vm/vm_fault.c
1088	Please do not do this. You are mixing VM_PAGER_XXX (pager errors namespace) and KERN_XXX (Mach errors). This is arguably incorrect in particular because the numeric values intersect. Translate the rest of errors into KERN_ as well.