Page MenuHomeFreeBSD

Move the fault getpages code into its own function.
ClosedPublic

Authored by jeff on Jan 22 2020, 3:03 AM.

Details

Summary

I left the readahead in the main loop because we don't need to repeat the dropbehind. However, storing the cached entry variables before unlocking the map was only done once before. I don't think this was important to the algorithm nor is it especially expensive.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 28837
Build 26845: arc lint + arc unit

Event Timeline

jeff created this revision.Jan 22 2020, 3:03 AM
jeff updated this revision to Diff 67132.Jan 22 2020, 3:08 AM

Fix a merge issue.

jeff edited the summary of this revision. (Show Details)Jan 22 2020, 3:10 AM
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository.
kib added inline comments.Jan 22 2020, 1:31 PM
sys/vm/vm_fault.c
1088

Please do not do this. You are mixing VM_PAGER_XXX (pager errors namespace) and KERN_XXX (Mach errors).

This is arguably incorrect in particular because the numeric values intersect. Translate the rest of errors into KERN_ as well.

jeff added inline comments.Jan 22 2020, 6:43 PM
sys/vm/vm_fault.c
1088

ah yes. Will do.

I would argue that we should convert the whole mess to errno but not today.

jeff updated this revision to Diff 67159.Jan 22 2020, 9:03 PM

Correct return values. Don't send pager errors back to vm_fault().

kib accepted this revision.Jan 22 2020, 9:11 PM
This revision is now accepted and ready to land.Jan 22 2020, 9:11 PM