Page MenuHomeFreeBSD
Differential D23311

Move the fault getpages code into its own function.
ClosedPublic
Actions

Authored by jeff on Jan 22 2020, 3:03 AM.
Tags
None
Referenced Files
F137045370: D23311.id67131.diff
Fri, Nov 21, 1:12 AM
F137044335: D23311.id67159.diff
Fri, Nov 21, 1:09 AM
F137043123: D23311.id67183.diff
Fri, Nov 21, 1:07 AM
F137042944: D23311.id.diff
Fri, Nov 21, 1:07 AM
F137042937: D23311.id67132.diff
Fri, Nov 21, 1:07 AM
F137041665: D23311.diff
Fri, Nov 21, 1:03 AM
F136906932: D23311.id67132.diff
Thu, Nov 20, 2:21 PM
F136906897: D23311.id67131.diff
Thu, Nov 20, 2:21 PM
View All Files
Subscribers
imp

Details

Reviewers
alc
dougm
kib
markj
Commits
rS357025: (fault 6/9) Move getpages and associated logic into a dedicated function.
Summary

I left the readahead in the main loop because we don't need to repeat the dropbehind. However, storing the cached entry variables before unlocking the map was only done once before. I don't think this was important to the algorithm nor is it especially expensive.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28836
Build 26844: arc lint + arc unit

Event Timeline

jeff created this revision.Jan 22 2020, 3:03 AM
Harbormaster completed remote builds in B28836: Diff 67131.Jan 22 2020, 3:03 AM
jeff updated this revision to Diff 67132.Jan 22 2020, 3:08 AM

Fix a merge issue.

Harbormaster completed remote builds in B28837: Diff 67132.Jan 22 2020, 3:08 AM
jeff edited the summary of this revision. (Show Details)Jan 22 2020, 3:10 AM
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJan 22 2020, 3:10 AM
kib added inline comments.Jan 22 2020, 1:31 PM
sys/vm/vm_fault.c
1088

Please do not do this. You are mixing VM_PAGER_XXX (pager errors namespace) and KERN_XXX (Mach errors).

This is arguably incorrect in particular because the numeric values intersect. Translate the rest of errors into KERN_ as well.

jeff added inline comments.Jan 22 2020, 6:43 PM
sys/vm/vm_fault.c
1088

ah yes. Will do.

I would argue that we should convert the whole mess to errno but not today.

jeff updated this revision to Diff 67159.Jan 22 2020, 9:03 PM

Correct return values. Don't send pager errors back to vm_fault().

Harbormaster completed remote builds in B28855: Diff 67159.Jan 22 2020, 9:03 PM
kib accepted this revision.Jan 22 2020, 9:11 PM
This revision is now accepted and ready to land.Jan 22 2020, 9:11 PM
Closed by commit rS357025: (fault 6/9) Move getpages and associated logic into a dedicated function. (authored by jeff). · Explain WhyJan 23 2020, 5:18 AM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS357025: (fault 6/9) Move getpages and associated logic into a dedicated function..

Revision Contents
Changeset List

PathSize
sys/
vm/
202 lines

Diff 67131

View Options

sys/vm/vm_fault.c

Loading...