Page MenuHomeFreeBSD
Differential D23302

Move map lookup into a separate function.
ClosedPublic
Actions

Authored by jeff on Jan 21 2020, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 20, 9:49 PM
Unknown Object (File)
Mon, Apr 20, 5:17 AM
Unknown Object (File)
Sun, Apr 19, 7:07 PM
Unknown Object (File)
Sun, Apr 19, 6:47 AM
Unknown Object (File)
Thu, Apr 16, 5:13 AM
Unknown Object (File)
Wed, Apr 15, 1:42 PM
Unknown Object (File)
Tue, Apr 14, 8:35 PM
Unknown Object (File)
Tue, Apr 14, 1:45 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
dougm
kib
markj
Commits
rS357021: (fault 2/9) Move map lookup into a dedicated function.
Summary

I'm not totally in love with the vm return codes. However, I am following a pattern that exists elsewhere in this file where RESOURCE_SHORTAGE means restart.

This should be functionally identical.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28824
Build 26832: arc lint + arc unit

Event Timeline

jeff created this revision.Jan 21 2020, 7:42 PM
Harbormaster completed remote builds in B28824: Diff 67114.Jan 21 2020, 7:42 PM
jeff edited the summary of this revision. (Show Details)Jan 21 2020, 7:51 PM
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJan 21 2020, 7:51 PM
kib accepted this revision.Jan 21 2020, 9:00 PM
kib added inline comments.
sys/vm/vm_fault.c
878

You can write this cleaner IMO:

if (result == KERN_RESOURCE_SHORTAGE)
        goto RetryFault;
if (result != KERN_SUCCESS)
         return (result);
This revision is now accepted and ready to land.Jan 21 2020, 9:00 PM
markj accepted this revision.Jan 22 2020, 8:21 PM
markj added inline comments.
sys/vm/vm_fault.c
878

Wouldn't that result in two comparisons instead of one in the common case?

Closed by commit rS357021: (fault 2/9) Move map lookup into a dedicated function. (authored by jeff). · Explain WhyJan 23 2020, 5:05 AM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS357021: (fault 2/9) Move map lookup into a dedicated function..

Revision Contents
Changeset List

PathSize
sys/
vm/
89 lines

Diff 67114

View Options

sys/vm/vm_fault.c

Loading...