Page MenuHomeFreeBSD

Move map lookup into a separate function.
ClosedPublic

Authored by jeff on Jan 21 2020, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 24, 10:51 PM
Unknown Object (File)
Fri, Oct 24, 10:51 PM
Unknown Object (File)
Fri, Oct 24, 10:51 PM
Unknown Object (File)
Fri, Oct 24, 4:42 PM
Unknown Object (File)
Tue, Oct 14, 12:44 AM
Unknown Object (File)
Sat, Oct 11, 11:09 PM
Unknown Object (File)
Sat, Oct 11, 8:39 PM
Unknown Object (File)
Sep 11 2025, 2:45 AM
Subscribers

Details

Summary

I'm not totally in love with the vm return codes. However, I am following a pattern that exists elsewhere in this file where RESOURCE_SHORTAGE means restart.

This should be functionally identical.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28824
Build 26832: arc lint + arc unit

Event Timeline

jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
kib added inline comments.
sys/vm/vm_fault.c
878

You can write this cleaner IMO:

if (result == KERN_RESOURCE_SHORTAGE)
        goto RetryFault;
if (result != KERN_SUCCESS)
         return (result);
This revision is now accepted and ready to land.Jan 21 2020, 9:00 PM
markj added inline comments.
sys/vm/vm_fault.c
878

Wouldn't that result in two comparisons instead of one in the common case?