Differential D23197
sysent targets: further cleanup and deduplication Authored by kevans on Jan 16 2020, 4:13 AM. Tags None Referenced Files
Details
rS355473 vastly improved the readability and cleanliness of these Makefiles. Every single one of them follows the same pattern and duplicates the exact same logic. Now that we have GENERATED/SRCS, split SRCS up into the two parameters we'll use for ${MAKESYSCALLS} rather than assuming a specific ordering of SRCS and include a common sysent.mk to handle the rest. This makes it less tedious to make sweeping changes.
Diff Detail
Event TimelineComment Actions Very nice cleanup. One think I notice upon review is that in every case except sys/kern/Makefile we have the same set of 5 files with a different prefix. I'm not sure it's worth addressing that, but I guess you could do something like GENERATED?=${COMMON_GENERATED:S/^/${GENERATED_PREFIX}} Comment Actions Ah, yes- that lets us easily reduce almost all of these to two lines (one assignment + include). I see that cheri also has a clean target in ^/sys/compat/cheriabi/Makefile; would it make sense to go ahead and add one to this common Makefile while I'm at it? It doesn't feel generally useful, but it also isn't harmful and the target would effectively just be rm -f ${GENERATED} at this point, and that Makefile could also probably use a similar (edit: cleanup, like these) with GENERATED_PREFIX=cheriabi_. (Even if it doesn't, I note that the sysent target is missing dependency on cheriabi_syscalls.c, not that it matters all that much) Comment Actions I don't think a clean target is very useful (you can always just do touch syscalls.master) I think freebsd32 had one and I copied it to cheriabi and then removed them in my last cleanup. Comment Actions Further cleanup- split list of commonly generated files out into sysent.mk and add GENERATED_PREFIX + default value for GENERATED so that most of the makefiles just need to set a prefix and maybe point to the proper sysent+config. |