Differential D23191

hexdump test: take into account byte order
ClosedPublic
Actions

Authored by renato.riolino_eldorado.org.br on Jan 15 2020, 2:25 PM.

Tags

Referenced Files

	F169562060: D23191.id.diff
	Tue, Sep 1, 10:32 PM

	F169425847: D23191.diff
	Tue, Sep 1, 12:36 PM

	Unknown Object (File)
	Mon, Aug 31, 9:07 PM

	Unknown Object (File)
	Mon, Aug 31, 5:38 PM

	Unknown Object (File)
	Mon, Aug 31, 5:35 AM

	Unknown Object (File)
	Mon, Aug 31, 3:08 AM

	Unknown Object (File)
	Mon, Aug 31, 2:40 AM

	Unknown Object (File)
	Sun, Aug 30, 10:52 PM

Subscribers

Details

Reviewers

kevans
cem
ngie

Commits

rS358553: hexdump: tests: take into account byte order

Summary

Hexdump test was failling on big endian systems when testing decimal, octal and hexa outputs

Test Plan

cd /usr/src/usr.bin/hexdump/tests/
make
make install
kyua test -k /usr/tests/usr.bin/hexdump/Kyuafile

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28684
Build 26706: arc lint + arc unit

Event Timeline

renato.riolino_eldorado.org.br created this revision.Jan 15 2020, 2:25 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 15 2020, 2:25 PM

Harbormaster completed remote builds in B28684: Diff 66782.Jan 15 2020, 2:25 PM

Seems like a good approach to me; the only nit I have to offer is that we oftentimes prefer spelling these "el" and "eb," but I suspect we have enough of a mix that it doesn't matter.

This revision is now accepted and ready to land.Jan 15 2020, 2:36 PM

Fix speeling "be" and "le" to "eb" and "el"

This revision now requires review to proceed.Jan 15 2020, 4:07 PM

Harbormaster completed remote builds in B28685: Diff 66787.Jan 15 2020, 4:08 PM

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

This revision is now accepted and ready to land.Jan 15 2020, 4:10 PM

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

Sure! I'm on ppc64 :p

Closed by commit rS358553: hexdump: tests: take into account byte order (authored by kevans). · Explain WhyMar 2 2020, 6:40 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS358553: hexdump: tests: take into account byte order.

Revision Contents
Changeset List

Path

Size

usr.bin/

hexdump/

tests/

27 lines

d_hexdump_dflag_a.out

d_hexdump_dflag_a_be.out

2 lines

	d_hexdump_dflag_a_le.out
	d_hexdump_dflag_a.out

2 lines

d_hexdump_dflag_b.out

d_hexdump_dflag_b_be.out

4 lines

	d_hexdump_dflag_b_le.out
	d_hexdump_dflag_b.out

4 lines

d_hexdump_dflag_c.out

	d_hexdump_dflag_c_be.out
	d_hexdump_dflag_c.out

2 lines

	d_hexdump_dflag_c_le.out
	d_hexdump_dflag_c.out

4 lines

d_hexdump_oflag_a.out

d_hexdump_oflag_a_be.out

2 lines

	d_hexdump_oflag_a_le.out
	d_hexdump_oflag_a.out

2 lines

d_hexdump_oflag_b.out

d_hexdump_oflag_b_be.out

4 lines

	d_hexdump_oflag_b_le.out
	d_hexdump_oflag_b.out

4 lines

d_hexdump_oflag_c.out

	d_hexdump_oflag_c_be.out
	d_hexdump_oflag_c.out

2 lines

	d_hexdump_oflag_c_le.out
	d_hexdump_oflag_c.out

4 lines

d_hexdump_xflag_a.out

d_hexdump_xflag_a_be.out

2 lines

	d_hexdump_xflag_a_le.out
	d_hexdump_xflag_a.out

2 lines

d_hexdump_xflag_b.out

d_hexdump_xflag_b_be.out

4 lines

	d_hexdump_xflag_b_le.out
	d_hexdump_xflag_b.out

4 lines

d_hexdump_xflag_c.out

	d_hexdump_xflag_c_be.out
	d_hexdump_xflag_c.out

2 lines

	d_hexdump_xflag_c_le.out
	d_hexdump_xflag_c.out

4 lines

hexdump_test.sh

24 lines

Diff 66782

usr.bin/hexdump/tests/Makefile

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_a.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_a_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_a_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_b.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_b_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_b_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_c.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_c_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_dflag_c_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_a.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_a_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_a_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_b.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_b_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_b_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_c.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_c_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_oflag_c_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_a.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_a_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_a_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_b.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_b_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_b_le.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_c.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_c_be.out

Loading...

usr.bin/hexdump/tests/d_hexdump_xflag_c_le.out

Loading...

usr.bin/hexdump/tests/hexdump_test.sh

Loading...