Hexdump test was failling on big endian systems when testing decimal, octal and hexa outputs
Details
Details
- Reviewers
kevans cem ngie - Commits
- rS358553: hexdump: tests: take into account byte order
cd /usr/src/usr.bin/hexdump/tests/
make
make install
kyua test -k /usr/tests/usr.bin/hexdump/Kyuafile
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 28684 Build 26706: arc lint + arc unit
Event Timeline
Comment Actions
Seems like a good approach to me; the only nit I have to offer is that we oftentimes prefer spelling these "el" and "eb," but I suspect we have enough of a mix that it doesn't matter.
Comment Actions
Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.
Comment Actions
Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.
Sure! I'm on ppc64 :p