- Switch to the new bootstrap that supports freebsd/arm64
- Sync with lang/go-devel port (add new makesum target, switch to dynamic pkg-plist generation)
Details
Details
Tested locally on 12.1-STABLE amd64, i386 and aarch64
exp-run?
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 28637 Build 26667: arc lint + arc unit
Event Timeline
Comment Actions
- exp-run is probably not needed for this update, but should maybe happen when 1.14 is released
- This looks like lang/go-devel now. Maybe it could be made a slave of lang/go later.
- Ever considered creating a golang@FreeBSD.org maintainer group?
| lang/go/Makefile | ||
|---|---|---|
| 90–97 | do-install, post-install could be merged and the two .for loops too. | |
| 111–121 | Similar to rP523409 in lang/rust, ${GREP} ${GOARCH_${arch}:U${arch}} ${DISTINFO_FILE}.${arch} >> ${DISTINFO_FILE}.tmp can be simplified to ${SED} 1d ${DISTINFO_FILE}.${arch} >> ${DISTINFO_FILE}.tmp. The awk command below takes care of removing duplicate lines afterwards. | |
| lang/go/Makefile | ||
|---|---|---|
| 111–121 | I've fixed this in lang/go-devel, will update this review when go1.14 is out. | |
| lang/go/Makefile | ||
|---|---|---|
| 57 | Do you plan to regenerate the bootstrap based on a release version? | |
| 68 | This should be 1200086 You can even put 12.1 since 12.0 is EOL on February 29, 2020 | |
| lang/go/Makefile | ||
|---|---|---|
| 57 | Yes, but I'd like to get this committed first. After that, I'll update both Go ports, and there's also https://reviews.freebsd.org/D23063 that was waiting for go1.14 | |